From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: "Smith, Elliot" <elliot.smith@intel.com>
Cc: toaster@yoctoproject.org
Subject: Re: [PATCH 4/6] toaster: add get_target_objects API
Date: Mon, 28 Sep 2015 14:16:56 +0300 [thread overview]
Message-ID: <20150928111656.GA13708@linux.intel.com> (raw)
In-Reply-To: <CA+1hgUivUSbtz-46Cg0NB_vcQKGOaai_hHOv-3-o5t-5ksXsjg@mail.gmail.com>
On Mon, Sep 28, 2015 at 10:41:07AM +0100, Smith, Elliot wrote:
> I think we should call this get_or_create_target_objects(), for consistency
> with existing methods, and also to highlight that the method has potential
> database writes as a side effect.
>
yep, agree. I'll send updated patchset for review soon.
--
Regards,
Ed
next prev parent reply other threads:[~2015-09-28 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 8:56 [PATCH 0/6] Fixes for toastergui Ed Bartosh
2015-09-28 8:57 ` [PATCH 1/6] event: add new property to BuildBase class Ed Bartosh
2015-09-28 8:57 ` [PATCH 2/6] event: add new parameter to Build* event APIs Ed Bartosh
2015-09-28 8:57 ` [PATCH 3/6] toaster: add task to the target_information Ed Bartosh
2015-09-28 8:57 ` [PATCH 4/6] toaster: add get_target_objects API Ed Bartosh
2015-09-28 9:41 ` Smith, Elliot
2015-09-28 11:16 ` Ed Bartosh [this message]
2015-09-28 8:57 ` [PATCH 5/6] toaster: ignore ReachableStamps event Ed Bartosh
2015-09-28 8:57 ` [PATCH 6/6] toaster: use meaningful logging levels Ed Bartosh
2015-09-28 11:14 ` [PATCH 0/6] Fixes for toastergui Smith, Elliot
2015-09-28 11:29 ` Barros Pena, Belen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928111656.GA13708@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=elliot.smith@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.