From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir
Date: Tue, 29 Sep 2015 15:55:38 +0200 [thread overview]
Message-ID: <20150929135538.GD7572@8bytes.org> (raw)
In-Reply-To: <1443511569-9187-2-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Tue, Sep 29, 2015 at 03:26:09PM +0800, Baoquan He wrote:
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 37b93f5..0f441b7 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -672,7 +672,7 @@ static int __init intel_prepare_irq_remapping(void)
> if (!dmar_ir_support())
> return -ENODEV;
>
> - if (parse_ioapics_under_ir() != 1) {
> + if (!parse_ioapics_under_ir()) {
> pr_info("Not enabling interrupt remapping\n");
> goto error;
> }
> @@ -918,7 +918,7 @@ static int __init parse_ioapics_under_ir(void)
> }
>
> if (!ir_supported)
> - return 0;
> + return -1;
>
> for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) {
> int ioapic_id = mpc_ioapic_id(ioapic_idx);
> @@ -930,7 +930,7 @@ static int __init parse_ioapics_under_ir(void)
> }
> }
>
> - return 1;
> + return 0;
Looks good, but -ENODEV is probably a better return value than -1.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir
Date: Tue, 29 Sep 2015 15:55:38 +0200 [thread overview]
Message-ID: <20150929135538.GD7572@8bytes.org> (raw)
In-Reply-To: <1443511569-9187-2-git-send-email-bhe@redhat.com>
On Tue, Sep 29, 2015 at 03:26:09PM +0800, Baoquan He wrote:
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 37b93f5..0f441b7 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -672,7 +672,7 @@ static int __init intel_prepare_irq_remapping(void)
> if (!dmar_ir_support())
> return -ENODEV;
>
> - if (parse_ioapics_under_ir() != 1) {
> + if (!parse_ioapics_under_ir()) {
> pr_info("Not enabling interrupt remapping\n");
> goto error;
> }
> @@ -918,7 +918,7 @@ static int __init parse_ioapics_under_ir(void)
> }
>
> if (!ir_supported)
> - return 0;
> + return -1;
>
> for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) {
> int ioapic_id = mpc_ioapic_id(ioapic_idx);
> @@ -930,7 +930,7 @@ static int __init parse_ioapics_under_ir(void)
> }
> }
>
> - return 1;
> + return 0;
Looks good, but -ENODEV is probably a better return value than -1.
Joerg
next prev parent reply other threads:[~2015-09-29 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 7:26 [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Baoquan He
2015-09-29 7:26 ` Baoquan He
[not found] ` <1443511569-9187-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-29 7:26 ` [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir Baoquan He
2015-09-29 7:26 ` Baoquan He
[not found] ` <1443511569-9187-2-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-29 13:55 ` Joerg Roedel [this message]
2015-09-29 13:55 ` Joerg Roedel
2015-09-29 13:50 ` [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Joerg Roedel
2015-09-29 13:50 ` Joerg Roedel
2015-09-29 15:04 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929135538.GD7572@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.