[sound:topic/firewire-update 15/15] sound/firewire/amdtp-am824.c:402:14: sparse: symbol 'process_rx_data_blocks' was not declared. Should it be static?

[sound:topic/firewire-update 15/15] sound/firewire/amdtp-am824.c:402:14: sparse: symbol 'process_rx_data_blocks' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/firewire-update
head:   df075feefbd347f13fba5198294cda619532c237
commit: df075feefbd347f13fba5198294cda619532c237 [15/15] ALSA: firewire-lib: complete AM824 data block processing layer
reproduce:
  # apt-get install sparse
  git checkout df075feefbd347f13fba5198294cda619532c237
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> sound/firewire/amdtp-am824.c:402:14: sparse: symbol 'process_rx_data_blocks' was not declared. Should it be static?
>> sound/firewire/amdtp-am824.c:423:14: sparse: symbol 'process_tx_data_blocks' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH sound] ALSA: firewire-lib: process_rx_data_blocks() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 amdtp-am824.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/firewire/amdtp-am824.c b/sound/firewire/amdtp-am824.c
index fe4b83f..bebddc6 100644
--- a/sound/firewire/amdtp-am824.c
+++ b/sound/firewire/amdtp-am824.c
@@ -399,8 +399,8 @@ static void read_midi_messages(struct amdtp_stream *s,
 	}
 }
 
-unsigned int process_rx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
-				    unsigned int data_blocks, unsigned int *syt)
+static unsigned int process_rx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
+					   unsigned int data_blocks, unsigned int *syt)
 {
 	struct amdtp_am824 *p = s->protocol;
 	struct snd_pcm_substream *pcm = ACCESS_ONCE(s->pcm);
@@ -420,8 +420,8 @@ unsigned int process_rx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
 	return pcm_frames;
 }
 
-unsigned int process_tx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
-				    unsigned int data_blocks, unsigned int *syt)
+static unsigned int process_tx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
+					   unsigned int data_blocks, unsigned int *syt)
 {
 	struct amdtp_am824 *p = s->protocol;
 	struct snd_pcm_substream *pcm = ACCESS_ONCE(s->pcm);

Re: [RFC PATCH sound] ALSA: firewire-lib: process_rx_data_blocks() can be static

[Takashi Iwai]

On Tue, 29 Sep 2015 16:46:10 +0200,
kbuild test robot wrote:
> 
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thanks.


Takashi

> ---
>  amdtp-am824.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/firewire/amdtp-am824.c b/sound/firewire/amdtp-am824.c
> index fe4b83f..bebddc6 100644
> --- a/sound/firewire/amdtp-am824.c
> +++ b/sound/firewire/amdtp-am824.c
> @@ -399,8 +399,8 @@ static void read_midi_messages(struct amdtp_stream *s,
>  	}
>  }
>  
> -unsigned int process_rx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
> -				    unsigned int data_blocks, unsigned int *syt)
> +static unsigned int process_rx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
> +					   unsigned int data_blocks, unsigned int *syt)
>  {
>  	struct amdtp_am824 *p = s->protocol;
>  	struct snd_pcm_substream *pcm = ACCESS_ONCE(s->pcm);
> @@ -420,8 +420,8 @@ unsigned int process_rx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
>  	return pcm_frames;
>  }
>  
> -unsigned int process_tx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
> -				    unsigned int data_blocks, unsigned int *syt)
> +static unsigned int process_tx_data_blocks(struct amdtp_stream *s, __be32 *buffer,
> +					   unsigned int data_blocks, unsigned int *syt)
>  {
>  	struct amdtp_am824 *p = s->protocol;
>  	struct snd_pcm_substream *pcm = ACCESS_ONCE(s->pcm);
>