From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting
Date: Tue, 29 Sep 2015 18:09:49 +0200 [thread overview]
Message-ID: <20150929160949.GP3036@8bytes.org> (raw)
In-Reply-To: <1443076656-31776-10-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Thu, Sep 24, 2015 at 02:37:35PM +0800, Baoquan He wrote:
> @@ -2469,6 +2469,8 @@ static dma_addr_t __map_single(struct device *dev,
> unsigned long align_mask = 0;
> int i;
>
> + if (translation_pre_enabled())
> + clear_translation_pre_enabled();
There is probably a better place to do this somewhere in the
initialization state machine of the AMD IOMMU driver.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting
Date: Tue, 29 Sep 2015 18:09:49 +0200 [thread overview]
Message-ID: <20150929160949.GP3036@8bytes.org> (raw)
In-Reply-To: <1443076656-31776-10-git-send-email-bhe@redhat.com>
On Thu, Sep 24, 2015 at 02:37:35PM +0800, Baoquan He wrote:
> @@ -2469,6 +2469,8 @@ static dma_addr_t __map_single(struct device *dev,
> unsigned long align_mask = 0;
> int i;
>
> + if (translation_pre_enabled())
> + clear_translation_pre_enabled();
There is probably a better place to do this somewhere in the
initialization state machine of the AMD IOMMU driver.
Joerg
next prev parent reply other threads:[~2015-09-29 16:09 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 6:37 [PATCH 00/10] Fix AMD IOMMU faults in kdump kernel Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` [PATCH 01/10] iommu/amd: Use standard bitmap operation to set bitmap Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` [PATCH 02/10] iommu/amd: Adjust functons which get first/last devid by reading pci config Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` [PATCH 03/10] iommu/amd: Get the first/last device of iommu earlier Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` [PATCH 04/10] iommu/amd: Detect pre enabled translation Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` [PATCH 05/10] iommu/amd: Add function copy_dev_tables Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` [PATCH 06/10] iommu/amd: Add functions copy_command_buffer/copy_event_buffer Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
[not found] ` <1443076656-31776-7-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-29 16:04 ` Joerg Roedel
2015-09-29 16:04 ` Joerg Roedel
2015-10-10 12:24 ` Baoquan He
2015-10-10 12:24 ` Baoquan He
2015-09-24 6:37 ` [PATCH 07/10] iommu/amd: copy old dev tables and do not touch dev tables Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
[not found] ` <1443076656-31776-8-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-29 16:08 ` Joerg Roedel
2015-09-29 16:08 ` Joerg Roedel
2015-10-10 12:28 ` Baoquan He
2015-10-10 12:28 ` Baoquan He
2015-10-10 12:28 ` Baoquan He
2015-09-24 6:37 ` [PATCH 08/10] iommu/amd: Do not update the information of domain to devtables before device driver init Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
[not found] ` <1443076656-31776-10-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-29 16:09 ` Joerg Roedel [this message]
2015-09-29 16:09 ` Joerg Roedel
2015-10-10 12:30 ` Baoquan He
2015-10-10 12:30 ` Baoquan He
2015-10-10 12:30 ` Baoquan He
2015-09-24 6:37 ` [PATCH 10/10] iommu/amd: Copy the old ir table Baoquan He
2015-09-24 6:37 ` Baoquan He
2015-09-24 6:37 ` Baoquan He
[not found] ` <1443076656-31776-11-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-29 16:11 ` Joerg Roedel
2015-09-29 16:11 ` Joerg Roedel
2015-10-10 12:40 ` Baoquan He
2015-10-10 12:40 ` Baoquan He
2015-10-10 12:40 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929160949.GP3036@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.