From: Brian Norris <computersforpeace@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: dwmw2@infradead.org, sebastian@breakpoint.cc, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
shawn.guo@linaro.org, kernel@pengutronix.de,
boris.brezillon@free-electrons.com, marb@ixxat.de,
aaron@tastycactus.com, bpringlemeir@gmail.com,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, albert.aribaud@3adev.fr,
klimov.linux@gmail.com, Bill Pringlemeir <bpringlemeir@nbsps.com>
Subject: Re: [PATCH v12 2/5] mtd: nand: vf610_nfc: add hardware BCH-ECC support
Date: Tue, 29 Sep 2015 13:57:27 -0700 [thread overview]
Message-ID: <20150929205727.GP31505@google.com> (raw)
In-Reply-To: <1441242397-870-3-git-send-email-stefan@agner.ch>
Pushed this patch to l2-mtd.git, as it looks pretty much good. Although,
I'd like raw read support...
On Wed, Sep 02, 2015 at 06:06:34PM -0700, Stefan Agner wrote:
> This adds hardware ECC support using the BCH encoder in the NFC IP.
> The ECC encoder supports up to 32-bit correction by using 60 error
> correction bytes. There is no sub-page ECC step, ECC is calculated
> always accross the whole page (up to 2k pages).
>
> Limitations:
> - HW ECC: Only 2K page with 64+ OOB.
> - HW ECC: Only 24 and 32-bit error correction implemented.
>
> Raw writes have been tested using the generic nand_write_page_raw
> implementation. However, raw reads are currently not possible
> because the controller need to know whether we are going to use
> the ECC mode already at NAND_CMD_READ0 command time. At this point
> we do not have the information whether it is a raw read or a
> regular read at driver level...
Hmm, can you get this in ecc.read_page_raw()?
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 2/5] mtd: nand: vf610_nfc: add hardware BCH-ECC support
Date: Tue, 29 Sep 2015 13:57:27 -0700 [thread overview]
Message-ID: <20150929205727.GP31505@google.com> (raw)
In-Reply-To: <1441242397-870-3-git-send-email-stefan@agner.ch>
Pushed this patch to l2-mtd.git, as it looks pretty much good. Although,
I'd like raw read support...
On Wed, Sep 02, 2015 at 06:06:34PM -0700, Stefan Agner wrote:
> This adds hardware ECC support using the BCH encoder in the NFC IP.
> The ECC encoder supports up to 32-bit correction by using 60 error
> correction bytes. There is no sub-page ECC step, ECC is calculated
> always accross the whole page (up to 2k pages).
>
> Limitations:
> - HW ECC: Only 2K page with 64+ OOB.
> - HW ECC: Only 24 and 32-bit error correction implemented.
>
> Raw writes have been tested using the generic nand_write_page_raw
> implementation. However, raw reads are currently not possible
> because the controller need to know whether we are going to use
> the ECC mode already at NAND_CMD_READ0 command time. At this point
> we do not have the information whether it is a raw read or a
> regular read at driver level...
Hmm, can you get this in ecc.read_page_raw()?
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
marb-Z4QKGCRq86k@public.gmane.org,
aaron-yuhzfaV+M/Wz3Dx2OeFgIA@public.gmane.org,
bpringlemeir-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
albert.aribaud-iEu9NFBzPZE@public.gmane.org,
klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Bill Pringlemeir
<bpringlemeir-ygJ1pmMJ17cAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v12 2/5] mtd: nand: vf610_nfc: add hardware BCH-ECC support
Date: Tue, 29 Sep 2015 13:57:27 -0700 [thread overview]
Message-ID: <20150929205727.GP31505@google.com> (raw)
In-Reply-To: <1441242397-870-3-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
Pushed this patch to l2-mtd.git, as it looks pretty much good. Although,
I'd like raw read support...
On Wed, Sep 02, 2015 at 06:06:34PM -0700, Stefan Agner wrote:
> This adds hardware ECC support using the BCH encoder in the NFC IP.
> The ECC encoder supports up to 32-bit correction by using 60 error
> correction bytes. There is no sub-page ECC step, ECC is calculated
> always accross the whole page (up to 2k pages).
>
> Limitations:
> - HW ECC: Only 2K page with 64+ OOB.
> - HW ECC: Only 24 and 32-bit error correction implemented.
>
> Raw writes have been tested using the generic nand_write_page_raw
> implementation. However, raw reads are currently not possible
> because the controller need to know whether we are going to use
> the ECC mode already at NAND_CMD_READ0 command time. At this point
> we do not have the information whether it is a raw read or a
> regular read at driver level...
Hmm, can you get this in ecc.read_page_raw()?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-29 20:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 1:06 [PATCH v12 0/5] mtd: nand: vf610_nfc: Freescale NFC for VF610 Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-03 1:06 ` [PATCH v12 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-04 4:10 ` Alexey Klimov
2015-09-04 4:10 ` Alexey Klimov
2015-09-04 4:10 ` Alexey Klimov
2015-09-29 20:55 ` Brian Norris
2015-09-29 20:55 ` Brian Norris
2015-09-03 1:06 ` [PATCH v12 2/5] mtd: nand: vf610_nfc: add hardware BCH-ECC support Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-29 20:57 ` Brian Norris [this message]
2015-09-29 20:57 ` Brian Norris
2015-09-29 20:57 ` Brian Norris
2015-10-07 23:34 ` Stefan Agner
2015-10-07 23:34 ` Stefan Agner
2015-09-03 1:06 ` [PATCH v12 3/5] mtd: nand: vf610_nfc: add device tree bindings Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-29 20:59 ` Brian Norris
2015-09-29 20:59 ` Brian Norris
2015-09-29 20:59 ` Brian Norris
2015-09-03 1:06 ` [PATCH v12 4/5] ARM: dts: vf610twr: add NAND flash controller peripherial Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-03 1:06 ` Stefan Agner
2015-09-03 1:06 ` [PATCH v12 5/5] ARM: dts: vf-colibri: enable NAND flash controller Stefan Agner
2015-09-03 1:06 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929205727.GP31505@google.com \
--to=computersforpeace@gmail.com \
--cc=aaron@tastycactus.com \
--cc=albert.aribaud@3adev.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=bpringlemeir@gmail.com \
--cc=bpringlemeir@nbsps.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=klimov.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marb@ixxat.de \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian@breakpoint.cc \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.