All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shivani Bhardwaj <shivanib134@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH] Drivers: power: max8997_charger: Fixed coding style and irrelevant messages
Date: Wed, 30 Sep 2015 02:52:57 +0530	[thread overview]
Message-ID: <20150929212257.GA13394@ubuntu> (raw)

Added blank line after declaration of variables
and commented out an unnecessary error print statement.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/power/max8997_charger.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/power/max8997_charger.c b/drivers/power/max8997_charger.c
index 0b2eab5..00127f3 100644
--- a/drivers/power/max8997_charger.c
+++ b/drivers/power/max8997_charger.c
@@ -106,6 +106,7 @@ static int max8997_battery_probe(struct platform_device *pdev)
 
 	if (pdata->eoc_mA) {
 		int val = (pdata->eoc_mA - 50) / 10;
+
 		if (val < 0)
 			val = 0;
 		if (val > 0xf)
@@ -149,7 +150,7 @@ static int max8997_battery_probe(struct platform_device *pdev)
 	charger = devm_kzalloc(&pdev->dev, sizeof(struct charger_data),
 				GFP_KERNEL);
 	if (charger == NULL) {
-		dev_err(&pdev->dev, "Cannot allocate memory.\n");
+		/*dev_err(&pdev->dev, "Cannot allocate memory.\n");*/
 		return -ENOMEM;
 	}
 
-- 
2.1.0



             reply	other threads:[~2015-09-29 21:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 21:22 Shivani Bhardwaj [this message]
2015-09-29 21:24 ` [Outreachy kernel] [PATCH] Drivers: power: max8997_charger: Fixed coding style and irrelevant messages Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929212257.GA13394@ubuntu \
    --to=shivanib134@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.