[PATCH] Drivers: power: max8997_charger: Fixed coding style and irrelevant messages

[PATCH] Drivers: power: max8997_charger: Fixed coding style and irrelevant messages

[Shivani Bhardwaj]

Added blank line after declaration of variables
and commented out an unnecessary error print statement.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/power/max8997_charger.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/power/max8997_charger.c b/drivers/power/max8997_charger.c
index 0b2eab5..00127f3 100644
--- a/drivers/power/max8997_charger.c
+++ b/drivers/power/max8997_charger.c
@@ -106,6 +106,7 @@ static int max8997_battery_probe(struct platform_device *pdev)
 
 	if (pdata->eoc_mA) {
 		int val = (pdata->eoc_mA - 50) / 10;
+
 		if (val < 0)
 			val = 0;
 		if (val > 0xf)
@@ -149,7 +150,7 @@ static int max8997_battery_probe(struct platform_device *pdev)
 	charger = devm_kzalloc(&pdev->dev, sizeof(struct charger_data),
 				GFP_KERNEL);
 	if (charger == NULL) {
-		dev_err(&pdev->dev, "Cannot allocate memory.\n");
+		/*dev_err(&pdev->dev, "Cannot allocate memory.\n");*/
 		return -ENOMEM;
 	}
 
-- 
2.1.0

Re: [Outreachy kernel] [PATCH] Drivers: power: max8997_charger: Fixed coding style and irrelevant messages

[Julia Lawall]

On Wed, 30 Sep 2015, Shivani Bhardwaj wrote:

> Added blank line after declaration of variables
> and commented out an unnecessary error print statement.

See the comments on the other two patches.  But another issue is that this 
does two completely unrelated things.  They should be in different 
patches, so that if one of them turns out not to be a good idea, it will 
be easier to just apply the other.

julia

> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/power/max8997_charger.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/max8997_charger.c b/drivers/power/max8997_charger.c
> index 0b2eab5..00127f3 100644
> --- a/drivers/power/max8997_charger.c
> +++ b/drivers/power/max8997_charger.c
> @@ -106,6 +106,7 @@ static int max8997_battery_probe(struct platform_device *pdev)
>  
>  	if (pdata->eoc_mA) {
>  		int val = (pdata->eoc_mA - 50) / 10;
> +
>  		if (val < 0)
>  			val = 0;
>  		if (val > 0xf)
> @@ -149,7 +150,7 @@ static int max8997_battery_probe(struct platform_device *pdev)
>  	charger = devm_kzalloc(&pdev->dev, sizeof(struct charger_data),
>  				GFP_KERNEL);
>  	if (charger == NULL) {
> -		dev_err(&pdev->dev, "Cannot allocate memory.\n");
> +		/*dev_err(&pdev->dev, "Cannot allocate memory.\n");*/
>  		return -ENOMEM;
>  	}
>  
> -- 
> 2.1.0
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150929212257.GA13394%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>