[PATCH] staging:dgnc: Fixed checkpatch warning

[PATCH] staging:dgnc: Fixed checkpatch warning

[Cristina Moraru]

Fixed 'suspect code indent for conditional statements (8, 24)' Warning

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
---
 drivers/staging/dgnc/dgnc_cls.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index a629a78..a2cfe35 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -632,9 +632,10 @@ static void cls_param(struct tty_struct *tty)
 		(ch->ch_c_cflag & CRTSCTS) ||
 		!(ch->ch_digi.digi_flags & DIGI_FORCEDCD) ||
 		!(ch->ch_c_cflag & CLOCAL))
-			ier |= UART_IER_MSI;
+
+		ier |= UART_IER_MSI;
 	else
-			ier &= ~UART_IER_MSI;
+		ier &= ~UART_IER_MSI;
 
 	ier |= UART_IER_THRI;
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] staging:dgnc: Fixed checkpatch warning

[Greg KH]

On Tue, Sep 29, 2015 at 02:36:08PM -0700, Cristina Moraru wrote:
> Fixed 'suspect code indent for conditional statements (8, 24)' Warning
> 
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index a629a78..a2cfe35 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -632,9 +632,10 @@ static void cls_param(struct tty_struct *tty)
>  		(ch->ch_c_cflag & CRTSCTS) ||
>  		!(ch->ch_digi.digi_flags & DIGI_FORCEDCD) ||
>  		!(ch->ch_c_cflag & CLOCAL))
> -			ier |= UART_IER_MSI;
> +
> +		ier |= UART_IER_MSI;
>  	else
> -			ier &= ~UART_IER_MSI;
> +		ier &= ~UART_IER_MSI;

Technically your change is correct, but ugh, the code is ugly now and
it's not obvious at all that the assignment of ier is what happens here
due to the indentation of the lines above it, right?

Can you please fix this to move the if statement lines to the left
correctly, so that the tab indentation of the ier line is now obvious?

Just do it all in one patch, I don't want to take this patch as-is.

thanks,

greg k-h