All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "河合英宏 / KAWAI，HIDEHIRO" <hidehiro.kawai.ez@hitachi.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Michal Hocko" <mhocko@kernel.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"平松雅巳 / HIRAMATU，MASAMI" <masami.hiramatsu.pt@hitachi.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Vivek Goyal" <vgoyal@redhat.com>
Subject: Re: [V4 PATCH 1/4] panic/x86: Fix re-entrance problem due to panic on NMI
Date: Wed, 30 Sep 2015 13:26:53 +0200	[thread overview]
Message-ID: <20150930112653.GF2881@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <04EAB7311EE43145B2D3536183D1A8445499083F@GSjpTKYDCembx31.service.hitachi.net>

On Fri, Sep 25, 2015 at 12:13:55PM +0000, 河合英宏 / KAWAI，HIDEHIRO wrote:
> Peter saids -tip tree doesn't have panic_on_unrecovered_nmi in the
> previoius discussion, but it still exists.  So, I didn't change
> anything about panic_on_unrecovered_nmi.
> 

> > --- a/arch/x86/kernel/nmi.c
> > +++ b/arch/x86/kernel/nmi.c
> > @@ -231,7 +231,7 @@ void unregister_nmi_handler(unsigned int type, const char *name)
> >  #endif
> > 
> >  	if (panic_on_unrecovered_nmi)
> > -		panic("NMI: Not continuing");
> > +		nmi_panic("NMI: Not continuing");
> > 
> >  	pr_emerg("Dazed and confused, but trying to continue\n");
> > 

I was looking at unregister_nmi_handler() because that's the function
the diff points to. That still doesn't have panic_on_unrecovered_nmi.

It looks like your diff tool is 'broken' and generates nonsense function
data.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: "河合英宏 / KAWAI，HIDEHIRO" <hidehiro.kawai.ez@hitachi.com>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Vivek Goyal" <vgoyal@redhat.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Michal Hocko" <mhocko@kernel.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"平松雅巳 / HIRAMATU，MASAMI" <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [V4 PATCH 1/4] panic/x86: Fix re-entrance problem due to panic on NMI
Date: Wed, 30 Sep 2015 13:26:53 +0200	[thread overview]
Message-ID: <20150930112653.GF2881@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <04EAB7311EE43145B2D3536183D1A8445499083F@GSjpTKYDCembx31.service.hitachi.net>

On Fri, Sep 25, 2015 at 12:13:55PM +0000, 河合英宏 / KAWAI，HIDEHIRO wrote:
> Peter saids -tip tree doesn't have panic_on_unrecovered_nmi in the
> previoius discussion, but it still exists.  So, I didn't change
> anything about panic_on_unrecovered_nmi.
> 

> > --- a/arch/x86/kernel/nmi.c
> > +++ b/arch/x86/kernel/nmi.c
> > @@ -231,7 +231,7 @@ void unregister_nmi_handler(unsigned int type, const char *name)
> >  #endif
> > 
> >  	if (panic_on_unrecovered_nmi)
> > -		panic("NMI: Not continuing");
> > +		nmi_panic("NMI: Not continuing");
> > 
> >  	pr_emerg("Dazed and confused, but trying to continue\n");
> > 

I was looking at unregister_nmi_handler() because that's the function
the diff points to. That still doesn't have panic_on_unrecovered_nmi.

It looks like your diff tool is 'broken' and generates nonsense function
data.

  reply	other threads:[~2015-09-30 11:26 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 11:28 [V4 PATCH 0/4] Fix race issues among panic, NMI and crash_kexec Hidehiro Kawai
2015-09-25 11:28 ` Hidehiro Kawai
2015-09-25 11:28 ` [V4 PATCH 1/4] panic/x86: Fix re-entrance problem due to panic on NMI Hidehiro Kawai
2015-09-25 11:28   ` Hidehiro Kawai
2015-09-25 12:13   ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-25 12:13     ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-30 11:26     ` Peter Zijlstra [this message]
2015-09-30 11:26       ` Peter Zijlstra
2015-10-01  1:02       ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01  1:02         ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context Hidehiro Kawai
2015-09-25 11:28   ` Hidehiro Kawai
2015-09-30 11:50   ` Peter Zijlstra
2015-09-30 11:50     ` Peter Zijlstra
2015-10-01  1:43     ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01  1:43       ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 3/4] kexec: Fix race between panic() and crash_kexec() called directly Hidehiro Kawai
2015-09-25 11:28   ` Hidehiro Kawai
2015-09-28  3:53   ` kbuild test robot
2015-09-28  3:53     ` kbuild test robot
2015-09-28  7:08     ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-28  7:08       ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-30 11:53       ` Peter Zijlstra
2015-09-30 11:53         ` Peter Zijlstra
2015-10-01  2:04         ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01  2:04           ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-28  4:02   ` kbuild test robot
2015-09-28  4:02     ` kbuild test robot
2015-09-28  4:46     ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-28  4:46       ` 河合英宏 / KAWAI，HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option Hidehiro Kawai
2015-09-25 11:28   ` Hidehiro Kawai
2015-09-30 11:55   ` Peter Zijlstra
2015-09-30 11:55     ` Peter Zijlstra
2015-10-01  2:33     ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01  2:33       ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01  6:27       ` Peter Zijlstra
2015-10-01  6:27         ` Peter Zijlstra
2015-10-01  7:01         ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01  7:01           ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01  8:43           ` Borislav Petkov
2015-10-01  8:43             ` Borislav Petkov
2015-10-01 10:24             ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01 10:24               ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-01 11:01               ` Borislav Petkov
2015-10-01 11:01                 ` Borislav Petkov
2015-10-02  0:58                 ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-02  0:58                   ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-02  7:47                   ` Borislav Petkov
2015-10-02  7:47                     ` Borislav Petkov
2015-10-05  2:03                     ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-05  2:03                       ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-05  8:27                       ` Borislav Petkov
2015-10-05  8:27                         ` Borislav Petkov
2015-10-05  9:21                         ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-05  9:21                           ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-05 10:14                           ` Borislav Petkov
2015-10-05 10:14                             ` Borislav Petkov
2015-10-13 11:55                             ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-13 11:55                               ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-13 20:19                         ` Thomas Gleixner
2015-10-14 13:54                           ` Ingo Molnar
2015-10-14 13:54                             ` Ingo Molnar
2015-10-16  1:58                             ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-16  1:58                               ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-13 20:22   ` Thomas Gleixner
2015-10-13 20:22     ` Thomas Gleixner
2015-10-14  3:39     ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-14  3:39       ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-14  7:25       ` Thomas Gleixner
2015-10-16  2:02         ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-16  2:02           ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-27  8:46   ` Baoquan He
2015-10-27  8:46     ` Baoquan He
2015-10-27  9:01     ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-27  9:01       ` 河合英宏 / KAWAI，HIDEHIRO
2015-10-27  9:06       ` 'Baoquan He'
2015-10-27  9:06         ` 'Baoquan He'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150930112653.GF2881@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=ebiederm@xmission.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mhocko@kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.