* [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM
@ 2015-09-30 12:20 Shraddha Barke
2015-09-30 12:20 ` [PATCH 2/2] Staging: fbtft: Remove debug messages related to DEBUG_BACKLIGHT Shraddha Barke
2015-09-30 12:48 ` [Outreachy kernel] [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM Aya Mahfouz
0 siblings, 2 replies; 3+ messages in thread
From: Shraddha Barke @ 2015-09-30 12:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Shraddha Barke
Remove debug messages related to fbtft_par_dbg(DEBUG_WRITE_VMEM.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 --
drivers/staging/fbtft/fb_pcd8544.c | 2 --
drivers/staging/fbtft/fb_ssd1306.c | 2 --
drivers/staging/fbtft/fb_tls8204.c | 2 --
drivers/staging/fbtft/fb_uc1611.c | 2 --
drivers/staging/fbtft/fb_uc1701.c | 2 --
drivers/staging/fbtft/fb_watterott.c | 4 ----
7 files changed, 16 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
index 2a2d53c..88718f6 100644
--- a/drivers/staging/fbtft/fb_agm1264k-fl.c
+++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
@@ -278,8 +278,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
if (!convert_buf)
return -ENOMEM;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
/* converting to grayscale16 */
for (x = 0; x < par->info->var.xres; ++x)
for (y = 0; y < par->info->var.yres; ++y) {
diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
index 828174a..8b52523 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -117,8 +117,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
int x, y, i;
int ret = 0;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
for (x = 0; x < 84; x++) {
for (y = 0; y < 6; y++) {
*buf = 0x00;
diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c
index 7568e94..568b433 100644
--- a/drivers/staging/fbtft/fb_ssd1306.c
+++ b/drivers/staging/fbtft/fb_ssd1306.c
@@ -165,8 +165,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
int x, y, i;
int ret = 0;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
for (x = 0; x < par->info->var.xres; x++) {
for (y = 0; y < par->info->var.yres/8; y++) {
*buf = 0x00;
diff --git a/drivers/staging/fbtft/fb_tls8204.c b/drivers/staging/fbtft/fb_tls8204.c
index 4e16ea7..d609f87 100644
--- a/drivers/staging/fbtft/fb_tls8204.c
+++ b/drivers/staging/fbtft/fb_tls8204.c
@@ -98,8 +98,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
int x, y, i;
int ret = 0;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
for (y = 0; y < HEIGHT / 8; y++) {
u8 *buf = par->txbuf.buf;
/* The display is 102x68 but the LCD is 84x48. Set
diff --git a/drivers/staging/fbtft/fb_uc1611.c b/drivers/staging/fbtft/fb_uc1611.c
index 5b83661..664e313 100644
--- a/drivers/staging/fbtft/fb_uc1611.c
+++ b/drivers/staging/fbtft/fb_uc1611.c
@@ -230,8 +230,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
int x, y, i;
int ret = 0;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
switch (par->pdata->display.buswidth) {
case 8:
switch (par->info->var.rotate) {
diff --git a/drivers/staging/fbtft/fb_uc1701.c b/drivers/staging/fbtft/fb_uc1701.c
index 28b13cf..28aa100 100644
--- a/drivers/staging/fbtft/fb_uc1701.c
+++ b/drivers/staging/fbtft/fb_uc1701.c
@@ -146,8 +146,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
int x, y, i;
int ret = 0;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
for (y = 0; y < PAGES; y++) {
buf = par->txbuf.buf;
for (x = 0; x < WIDTH; x++) {
diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
index c480049..9c2f0e3 100644
--- a/drivers/staging/fbtft/fb_watterott.c
+++ b/drivers/staging/fbtft/fb_watterott.c
@@ -74,8 +74,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
int i, j;
int ret = 0;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
start_line = offset / par->info->fix.line_length;
end_line = start_line + (len / par->info->fix.line_length) - 1;
@@ -113,8 +111,6 @@ static int write_vmem_8bit(struct fbtft_par *par, size_t offset, size_t len)
int i, j;
int ret = 0;
- fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
-
start_line = offset / par->info->fix.line_length;
end_line = start_line + (len / par->info->fix.line_length) - 1;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] Staging: fbtft: Remove debug messages related to DEBUG_BACKLIGHT
2015-09-30 12:20 [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM Shraddha Barke
@ 2015-09-30 12:20 ` Shraddha Barke
2015-09-30 12:48 ` [Outreachy kernel] [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM Aya Mahfouz
1 sibling, 0 replies; 3+ messages in thread
From: Shraddha Barke @ 2015-09-30 12:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Shraddha Barke
Remove debug messages related to fbtft_par_dbg(DEBUG_BACKLIGHT.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/fbtft/fb_ssd1351.c | 2 --
drivers/staging/fbtft/fb_watterott.c | 2 --
drivers/staging/fbtft/fbtft-core.c | 4 ----
3 files changed, 8 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
index 83867e1..eb45b27 100644
--- a/drivers/staging/fbtft/fb_ssd1351.c
+++ b/drivers/staging/fbtft/fb_ssd1351.c
@@ -206,8 +206,6 @@ static void register_onboard_backlight(struct fbtft_par *par)
struct backlight_device *bd;
struct backlight_properties bl_props = { 0, };
- fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
-
bl_props.type = BACKLIGHT_RAW;
bl_props.power = FB_BLANK_POWERDOWN;
diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
index 9c2f0e3..2be2f66 100644
--- a/drivers/staging/fbtft/fb_watterott.c
+++ b/drivers/staging/fbtft/fb_watterott.c
@@ -253,8 +253,6 @@ static void register_chip_backlight(struct fbtft_par *par)
struct backlight_device *bd;
struct backlight_properties bl_props = { 0, };
- fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
-
bl_props.type = BACKLIGHT_RAW;
bl_props.power = FB_BLANK_POWERDOWN;
bl_props.max_brightness = 100;
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index b318daf..c26e624 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -266,8 +266,6 @@ static int fbtft_backlight_get_brightness(struct backlight_device *bd)
void fbtft_unregister_backlight(struct fbtft_par *par)
{
- fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
-
if (par->info->bl_dev) {
par->info->bl_dev->props.power = FB_BLANK_POWERDOWN;
backlight_update_status(par->info->bl_dev);
@@ -286,8 +284,6 @@ void fbtft_register_backlight(struct fbtft_par *par)
struct backlight_device *bd;
struct backlight_properties bl_props = { 0, };
- fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
-
if (par->gpio.led[0] == -1) {
fbtft_par_dbg(DEBUG_BACKLIGHT, par,
"%s(): led pin not set, exiting.\n", __func__);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM
2015-09-30 12:20 [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM Shraddha Barke
2015-09-30 12:20 ` [PATCH 2/2] Staging: fbtft: Remove debug messages related to DEBUG_BACKLIGHT Shraddha Barke
@ 2015-09-30 12:48 ` Aya Mahfouz
1 sibling, 0 replies; 3+ messages in thread
From: Aya Mahfouz @ 2015-09-30 12:48 UTC (permalink / raw)
To: Shraddha Barke; +Cc: outreachy-kernel
On Wed, Sep 30, 2015 at 05:50:32PM +0530, Shraddha Barke wrote:
Hello Shraddha,
Nice effort done there. But you forgot the cover letter for this
patch set. Check the section 'Submitting a patchset' in:
http://kernelnewbies.org/Outreachyfirstpatch
for instructions to generate a patchset and its cover letter.
> Remove debug messages related to fbtft_par_dbg(DEBUG_WRITE_VMEM.. )
> as this info can be obtained using kernel function tracer
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/fbtft/fb_agm1264k-fl.c | 2 --
> drivers/staging/fbtft/fb_pcd8544.c | 2 --
> drivers/staging/fbtft/fb_ssd1306.c | 2 --
> drivers/staging/fbtft/fb_tls8204.c | 2 --
> drivers/staging/fbtft/fb_uc1611.c | 2 --
> drivers/staging/fbtft/fb_uc1701.c | 2 --
> drivers/staging/fbtft/fb_watterott.c | 4 ----
> 7 files changed, 16 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index 2a2d53c..88718f6 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -278,8 +278,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> if (!convert_buf)
> return -ENOMEM;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> /* converting to grayscale16 */
> for (x = 0; x < par->info->var.xres; ++x)
> for (y = 0; y < par->info->var.yres; ++y) {
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index 828174a..8b52523 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -117,8 +117,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> int x, y, i;
> int ret = 0;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> for (x = 0; x < 84; x++) {
> for (y = 0; y < 6; y++) {
> *buf = 0x00;
> diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c
> index 7568e94..568b433 100644
> --- a/drivers/staging/fbtft/fb_ssd1306.c
> +++ b/drivers/staging/fbtft/fb_ssd1306.c
> @@ -165,8 +165,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> int x, y, i;
> int ret = 0;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> for (x = 0; x < par->info->var.xres; x++) {
> for (y = 0; y < par->info->var.yres/8; y++) {
> *buf = 0x00;
> diff --git a/drivers/staging/fbtft/fb_tls8204.c b/drivers/staging/fbtft/fb_tls8204.c
> index 4e16ea7..d609f87 100644
> --- a/drivers/staging/fbtft/fb_tls8204.c
> +++ b/drivers/staging/fbtft/fb_tls8204.c
> @@ -98,8 +98,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> int x, y, i;
> int ret = 0;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> for (y = 0; y < HEIGHT / 8; y++) {
> u8 *buf = par->txbuf.buf;
> /* The display is 102x68 but the LCD is 84x48. Set
> diff --git a/drivers/staging/fbtft/fb_uc1611.c b/drivers/staging/fbtft/fb_uc1611.c
> index 5b83661..664e313 100644
> --- a/drivers/staging/fbtft/fb_uc1611.c
> +++ b/drivers/staging/fbtft/fb_uc1611.c
> @@ -230,8 +230,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> int x, y, i;
> int ret = 0;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> switch (par->pdata->display.buswidth) {
> case 8:
> switch (par->info->var.rotate) {
> diff --git a/drivers/staging/fbtft/fb_uc1701.c b/drivers/staging/fbtft/fb_uc1701.c
> index 28b13cf..28aa100 100644
> --- a/drivers/staging/fbtft/fb_uc1701.c
> +++ b/drivers/staging/fbtft/fb_uc1701.c
> @@ -146,8 +146,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> int x, y, i;
> int ret = 0;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> for (y = 0; y < PAGES; y++) {
> buf = par->txbuf.buf;
> for (x = 0; x < WIDTH; x++) {
> diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
> index c480049..9c2f0e3 100644
> --- a/drivers/staging/fbtft/fb_watterott.c
> +++ b/drivers/staging/fbtft/fb_watterott.c
> @@ -74,8 +74,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> int i, j;
> int ret = 0;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> start_line = offset / par->info->fix.line_length;
> end_line = start_line + (len / par->info->fix.line_length) - 1;
>
> @@ -113,8 +111,6 @@ static int write_vmem_8bit(struct fbtft_par *par, size_t offset, size_t len)
> int i, j;
> int ret = 0;
>
> - fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
> -
> start_line = offset / par->info->fix.line_length;
> end_line = start_line + (len / par->info->fix.line_length) - 1;
>
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1443615633-5978-1-git-send-email-shraddha.6596%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
--
Kind Regards,
Aya Saif El-yazal Mahfouz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-30 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-30 12:20 [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM Shraddha Barke
2015-09-30 12:20 ` [PATCH 2/2] Staging: fbtft: Remove debug messages related to DEBUG_BACKLIGHT Shraddha Barke
2015-09-30 12:48 ` [Outreachy kernel] [PATCH 1/2] Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM Aya Mahfouz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.