[PATCH] Staging: lustre: ptlrpc: nrs_fifo: Removed an unused structure

[PATCH] Staging: lustre: ptlrpc: nrs_fifo: Removed an unused structure

[Shivani Bhardwaj]

Removed a structure "nrs_conf_fifo" because it was not called/referenced
in the entire code.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c b/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c
index 8e21f0c..6be1adb 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c
@@ -259,13 +259,6 @@ static const struct ptlrpc_nrs_pol_ops nrs_fifo_ops = {
 /**
  * FIFO policy configuration
  */
-struct ptlrpc_nrs_pol_conf nrs_conf_fifo = {
-	.nc_name		= NRS_POL_NAME_FIFO,
-	.nc_ops			= &nrs_fifo_ops,
-	.nc_compat		= nrs_policy_compat_all,
-	.nc_flags		= PTLRPC_NRS_FL_FALLBACK |
-				  PTLRPC_NRS_FL_REG_START
-};
 
 /** @} fifo */
 
-- 
2.1.0

Re: [Outreachy kernel] [PATCH] Staging: lustre: ptlrpc: nrs_fifo: Removed an unused structure

[Vaishali Thakkar]

On Thu, Oct 1, 2015 at 1:15 PM, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> Removed a structure "nrs_conf_fifo" because it was not called/referenced
> in the entire code.

It is called in the file drivers/staging/lustre/lustre/ptlrpc/nrs.c.

Here: http://lxr.free-electrons.com/source/drivers/staging/lustre/lustre/ptlrpc/nrs.c#L1719

Please check with 'git grep' when you are doing such changes. I think
compiler should have warned you about the same.

> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c b/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c
> index 8e21f0c..6be1adb 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c
> @@ -259,13 +259,6 @@ static const struct ptlrpc_nrs_pol_ops nrs_fifo_ops = {
>  /**
>   * FIFO policy configuration
>   */
> -struct ptlrpc_nrs_pol_conf nrs_conf_fifo = {
> -       .nc_name                = NRS_POL_NAME_FIFO,
> -       .nc_ops                 = &nrs_fifo_ops,
> -       .nc_compat              = nrs_policy_compat_all,
> -       .nc_flags               = PTLRPC_NRS_FL_FALLBACK |
> -                                 PTLRPC_NRS_FL_REG_START
> -};
>
>  /** @} fifo */
>
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151001074538.GA39335%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.



-- 
Vaishali