All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi][PATCH v5] ARM: sun7i: dt: Add new Olimex A20 EVB device
Date: Thu, 1 Oct 2015 15:09:32 +0200	[thread overview]
Message-ID: <20151001130932.GJ7104@lukather> (raw)
In-Reply-To: <CAEKpxB=ytV17o5uO6srDbJSrvNe66EeRERF-Ow=HuzE4=z1qag@mail.gmail.com>

On Thu, Oct 01, 2015 at 02:54:07PM +0200, Code Kipper wrote:
> >> +&reg_dcdc2 {
> >> +     regulator-always-on;
> >> +     regulator-min-microvolt = <1000000>;
> >> +     regulator-max-microvolt = <1425000>;
> >
> > You also changed that since v4, for an unknown reason, and without
> > mentionning it in the changelog...
>
> AAARRRGGGGHHHHHHHHHHH....could you kindly fix this for me?....pllllleeeasseee.

If that's the only change you made, sure...

But you should pay more attention and / or polish your git
workflow. Having part of codes from several versions ago poping back
is definitely not good.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151001/33dbb9bf/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Code Kipper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH v5] ARM: sun7i: dt: Add new Olimex A20 EVB device
Date: Thu, 1 Oct 2015 15:09:32 +0200	[thread overview]
Message-ID: <20151001130932.GJ7104@lukather> (raw)
In-Reply-To: <CAEKpxB=ytV17o5uO6srDbJSrvNe66EeRERF-Ow=HuzE4=z1qag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

On Thu, Oct 01, 2015 at 02:54:07PM +0200, Code Kipper wrote:
> >> +&reg_dcdc2 {
> >> +     regulator-always-on;
> >> +     regulator-min-microvolt = <1000000>;
> >> +     regulator-max-microvolt = <1425000>;
> >
> > You also changed that since v4, for an unknown reason, and without
> > mentionning it in the changelog...
>
> AAARRRGGGGHHHHHHHHHHH....could you kindly fix this for me?....pllllleeeasseee.

If that's the only change you made, sure...

But you should pay more attention and / or polish your git
workflow. Having part of codes from several versions ago poping back
is definitely not good.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-10-01 13:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 17:34 [linux-sunxi][PATCH v5] ARM: sun7i: dt: Add new Olimex A20 EVB device codekipper at gmail.com
2015-09-30 17:34 ` [PATCH " codekipper-Re5JQEeQqe8AvxtiuMwx3w
2015-10-01 12:06 ` [linux-sunxi][PATCH " Maxime Ripard
2015-10-01 12:06   ` [PATCH " Maxime Ripard
2015-10-01 12:54   ` [linux-sunxi][PATCH " Code Kipper
2015-10-01 12:54     ` [PATCH " Code Kipper
2015-10-01 13:09     ` Maxime Ripard [this message]
2015-10-01 13:09       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001130932.GJ7104@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.