[PATCH v2] Staging: board: Removed unnecessary header file

[PATCH v2] Staging: board: Removed unnecessary header file

[Shivani Bhardwaj]

Fixed the problem with previous version by removing the unnecessary
header file that was added in previous version.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/board/board.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c
index 8d0ac82..edbc590 100644
--- a/drivers/staging/board/board.c
+++ b/drivers/staging/board/board.c
@@ -19,8 +19,6 @@
 #include <linux/of_irq.h>
 #include <linux/platform_device.h>
 #include <linux/pm_domain.h>
-#include <asm/prom.h>
-
 #include "board.h"
 
 static struct device_node *irqc_node __initdata;
-- 
2.1.0

Re: [Outreachy kernel] [PATCH v2] Staging: board: Removed unnecessary header file

[Vaishali Thakkar]

On Fri, Oct 2, 2015 at 1:48 PM, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> Fixed the problem with previous version by removing the unnecessary
> header file that was added in previous version.

Hi,

Version 2 should be on top of the actual file and not on the version 1
of the patch.

> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/board/board.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c
> index 8d0ac82..edbc590 100644
> --- a/drivers/staging/board/board.c
> +++ b/drivers/staging/board/board.c
> @@ -19,8 +19,6 @@
>  #include <linux/of_irq.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_domain.h>
> -#include <asm/prom.h>
> -
>  #include "board.h"
>
>  static struct device_node *irqc_node __initdata;
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151002081827.GA56279%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.



-- 
Vaishali

Re: [Outreachy kernel] [PATCH v2] Staging: board: Removed unnecessary header file

[Julia Lawall]

On Fri, 2 Oct 2015, Shivani Bhardwaj wrote:

> Fixed the problem with previous version by removing the unnecessary
> header file that was added in previous version.

This is not the right way to make a v2.  Your v1 will not be accepted, so
your v2 work should be based on the original code, not the result of your
previous patch.  Put the changes for v2 under the ---

However, are you sure that it is the header that is not needed, and nothe
local declaration that is not needed?

julia

> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/board/board.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c
> index 8d0ac82..edbc590 100644
> --- a/drivers/staging/board/board.c
> +++ b/drivers/staging/board/board.c
> @@ -19,8 +19,6 @@
>  #include <linux/of_irq.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_domain.h>
> -#include <asm/prom.h>
> -
>  #include "board.h"
>
>  static struct device_node *irqc_node __initdata;
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151002081827.GA56279%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>