All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	kernel@pengutronix.de, patchwork-lst@pengutronix.de
Subject: Re: [PATCH v4 0/8] i.MX early debug UART clock fixes
Date: Fri, 2 Oct 2015 12:45:28 -0700	[thread overview]
Message-ID: <20151002194528.GX12338@codeaurora.org> (raw)
In-Reply-To: <1443108993.8476.10.camel@pengutronix.de>

On 09/24, Lucas Stach wrote:
> Am Donnerstag, den 24.09.2015, 08:20 -0700 schrieb Shawn Guo:
> > On Mon, Sep 21, 2015 at 06:53:56PM +0200, Lucas Stach wrote:
> > > This series fixes a long standing interaction issue between the
> > > kernels early debug facilities and the i.MX clock drivers.
> > 
> > This is fixing some issue but not regression.  As the change basically
> > has influence on all i.MX platforms, my take is that we should get them
> > into linux-next for extensive testing and queue for 4.4.  Agree?
> > 
> Absolutely, this fixes a bug which should mostly hit developers running
> with earlyprintk or earlycon, so it's definitely not fixes material.
> 
> Please queue it up for 4.4.

Patches look mostly ok to me, but this certainly feels like some
generic problem that we should handle in the core. Perhaps it
would make sense to move this over to using the handoff mechanism
Mike is working on, where we keep the clock on until a consumer
grabs a reference to the clock?

So I'm not opposed to merging this for 4.4, but I'd like to see
it become a generic solution sometime soon, instead of staying as
a one-off fix for imx platforms.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/8] i.MX early debug UART clock fixes
Date: Fri, 2 Oct 2015 12:45:28 -0700	[thread overview]
Message-ID: <20151002194528.GX12338@codeaurora.org> (raw)
In-Reply-To: <1443108993.8476.10.camel@pengutronix.de>

On 09/24, Lucas Stach wrote:
> Am Donnerstag, den 24.09.2015, 08:20 -0700 schrieb Shawn Guo:
> > On Mon, Sep 21, 2015 at 06:53:56PM +0200, Lucas Stach wrote:
> > > This series fixes a long standing interaction issue between the
> > > kernels early debug facilities and the i.MX clock drivers.
> > 
> > This is fixing some issue but not regression.  As the change basically
> > has influence on all i.MX platforms, my take is that we should get them
> > into linux-next for extensive testing and queue for 4.4.  Agree?
> > 
> Absolutely, this fixes a bug which should mostly hit developers running
> with earlyprintk or earlycon, so it's definitely not fixes material.
> 
> Please queue it up for 4.4.

Patches look mostly ok to me, but this certainly feels like some
generic problem that we should handle in the core. Perhaps it
would make sense to move this over to using the handoff mechanism
Mike is working on, where we keep the clock on until a consumer
grabs a reference to the clock?

So I'm not opposed to merging this for 4.4, but I'd like to see
it become a generic solution sometime soon, instead of staying as
a one-off fix for imx platforms.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-10-02 19:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 16:53 [PATCH v4 0/8] i.MX early debug UART clock fixes Lucas Stach
2015-09-21 16:53 ` Lucas Stach
2015-09-21 16:53 ` [PATCH v4 1/8] clk: imx: add common logic to detect early UART usage Lucas Stach
2015-09-21 16:53   ` Lucas Stach
2015-09-21 17:56   ` Fabio Estevam
2015-09-21 17:56     ` Fabio Estevam
2015-09-23 10:02     ` Lucas Stach
2015-09-23 10:02       ` Lucas Stach
2015-09-21 16:53 ` [PATCH v4 2/8] clk: imx25: retain early UART clocks during kernel init Lucas Stach
2015-09-21 16:53   ` Lucas Stach
2015-09-21 16:53 ` [PATCH v4 3/8] clk: imx27: " Lucas Stach
2015-09-21 16:53   ` Lucas Stach
2015-09-21 16:54 ` [PATCH v4 4/8] clk: imx31: " Lucas Stach
2015-09-21 16:54   ` Lucas Stach
2015-09-21 16:54 ` [PATCH v4 5/8] clk: imx35: " Lucas Stach
2015-09-21 16:54   ` Lucas Stach
2015-09-21 16:54 ` [PATCH v4 6/8] clk: imx5: " Lucas Stach
2015-09-21 16:54   ` Lucas Stach
2015-09-21 16:54 ` [PATCH v4 7/8] clk: imx6: " Lucas Stach
2015-09-21 16:54   ` Lucas Stach
2015-09-21 16:54 ` [PATCH v4 8/8] clk: imx7d: " Lucas Stach
2015-09-21 16:54   ` Lucas Stach
2015-09-24 15:20 ` [PATCH v4 0/8] i.MX early debug UART clock fixes Shawn Guo
2015-09-24 15:20   ` Shawn Guo
2015-09-24 15:36   ` Lucas Stach
2015-09-24 15:36     ` Lucas Stach
2015-10-02 19:45     ` Stephen Boyd [this message]
2015-10-02 19:45       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002194528.GX12338@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=patchwork-lst@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.