Re: [PATCH bluetooth-next] nl802154: fix rtnl_unlock() being missing

[Alexander Aring <alex.aring@gmail.com>]

Hi Jean,

On Fri, Oct 02, 2015 at 10:46:52PM -0600, Jεan Sacren wrote:
> From: Jean Sacren <sakiwit@gmail.com>
> 
> In nl802154_prepare_wpan_dev_dump(), rtnl_unlock() was missing if it

There is no rtnl_unlock missing, the rtnl_unlock call will be done by
function "nl802154_finish_wpan_dev_dump".

The rtnl lock need to be held at the full netlink _dump_ callback, e.g.:

1. call nl802154_prepare_wpan_dev_dump

2. doing netlink things

3. nl802154_finish_wpan_dev_dump

The 3. point is important and we have a bug if we don't call
"nl802154_finish_wpan_dev_dump" at least. Except
"nl802154_prepare_wpan_dev_dump" returns an error.


This mechanism was copy&pasted(with minor changes) from wireless which
we use as reference design. If you like to change this behaviour, then
you need to first change it in wireless, then here.

The identical function can be found at [0].

btw:
Doing some shared code between wireless/802.15.4 would be great but at
first we try to reach some stable subsystem implementation.

- Alex

[0] http://lxr.free-electrons.com/source/net/wireless/nl80211.c#L481