From: "Jεan Sacren" <sakiwit@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: linux-wpan@vger.kernel.org
Subject: Re: [PATCH bluetooth-next] nl802154: fix rtnl_unlock() being missing
Date: Sat, 3 Oct 2015 02:40:25 -0600 [thread overview]
Message-ID: <20151003084025.GA9771@mail.gmail.com> (raw)
In-Reply-To: <20151003064413.GA7178@omega>
From: Alexander Aring <alex.aring@gmail.com>
Date: Sat, 03 Oct 2015 08:44:14 +0200
>
> Hi Jean,
>
> On Fri, Oct 02, 2015 at 10:46:52PM -0600, Jεan Sacren wrote:
> > From: Jean Sacren <sakiwit@gmail.com>
> >
> > In nl802154_prepare_wpan_dev_dump(), rtnl_unlock() was missing if it
>
> There is no rtnl_unlock missing, the rtnl_unlock call will be done by
> function "nl802154_finish_wpan_dev_dump".
>
> The rtnl lock need to be held at the full netlink _dump_ callback, e.g.:
>
> 1. call nl802154_prepare_wpan_dev_dump
>
> 2. doing netlink things
>
> 3. nl802154_finish_wpan_dev_dump
I'm so sorry. Thank you for teaching me again.
prev parent reply other threads:[~2015-10-03 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 4:46 [PATCH bluetooth-next] nl802154: fix rtnl_unlock() being missing Jεan Sacren
2015-10-03 6:44 ` Alexander Aring
2015-10-03 6:57 ` Alexander Aring
2015-10-03 8:40 ` Jεan Sacren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003084025.GA9771@mail.gmail.com \
--to=sakiwit@gmail.com \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.