From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Harald Geyer <harald@ccbib.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Wim Van Sebroeck <wim@iguana.be>,
rtc-linux@googlegroups.com, linux-watchdog@vger.kernel.org,
kernel@pengutronix.de
Subject: [rtc-linux] Re: [PATCH 2/2] watchdog: stmp3xxx: Implement GETBOOTSTATUS
Date: Sat, 3 Oct 2015 18:47:35 +0200 [thread overview]
Message-ID: <20151003164735.GF2694@piout.net> (raw)
In-Reply-To: <1443817082-24370-2-git-send-email-harald@ccbib.org>
Hi,
On 02/10/2015 at 20:18:02 +0000, Harald Geyer wrote :
> +static void stmp3xxx_wdt_clear_bootstatus(struct device *dev)
> +{
> + struct stmp3xxx_rtc_data *rtc_data = dev_get_drvdata(dev);
> +
> + writel(STMP3XXX_RTC_PERSISTENT2_WDT_ACTIVE,
> + STMP3XXX_RTC_PERSISTENT2 + STMP_OFFSET_REG_CLR + rtc_data->io);
nitpick: I would put rtc_data->io first here for consistency.
Else, this seems fine to me, I can take that patch with the watchdog
maintainers ack.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Harald Geyer <harald@ccbib.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Wim Van Sebroeck <wim@iguana.be>,
rtc-linux@googlegroups.com, linux-watchdog@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] watchdog: stmp3xxx: Implement GETBOOTSTATUS
Date: Sat, 3 Oct 2015 18:47:35 +0200 [thread overview]
Message-ID: <20151003164735.GF2694@piout.net> (raw)
In-Reply-To: <1443817082-24370-2-git-send-email-harald@ccbib.org>
Hi,
On 02/10/2015 at 20:18:02 +0000, Harald Geyer wrote :
> +static void stmp3xxx_wdt_clear_bootstatus(struct device *dev)
> +{
> + struct stmp3xxx_rtc_data *rtc_data = dev_get_drvdata(dev);
> +
> + writel(STMP3XXX_RTC_PERSISTENT2_WDT_ACTIVE,
> + STMP3XXX_RTC_PERSISTENT2 + STMP_OFFSET_REG_CLR + rtc_data->io);
nitpick: I would put rtc_data->io first here for consistency.
Else, this seems fine to me, I can take that patch with the watchdog
maintainers ack.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-03 16:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 20:18 [rtc-linux] [PATCH 1/2] rtc: stmp3xxx: unify register access macros Harald Geyer
2015-10-02 20:18 ` Harald Geyer
2015-10-02 20:18 ` [rtc-linux] [PATCH 2/2] watchdog: stmp3xxx: Implement GETBOOTSTATUS Harald Geyer
2015-10-02 20:18 ` Harald Geyer
2015-10-03 16:47 ` Alexandre Belloni [this message]
2015-10-03 16:47 ` Alexandre Belloni
2015-10-03 15:57 ` [rtc-linux] Re: [PATCH 1/2] rtc: stmp3xxx: unify register access macros Alexandre Belloni
2015-10-03 15:57 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2015-10-07 12:19 [rtc-linux] [PATCHv3 1/2] watchdog: stmp3xxx: Stop the watchdog on system halt Harald Geyer
2015-10-07 12:19 ` [rtc-linux] [PATCH 2/2] watchdog: stmp3xxx: Implement GETBOOTSTATUS Harald Geyer
2015-11-26 9:25 ` [rtc-linux] " Uwe Kleine-König
2015-11-26 13:39 ` Harald Geyer
2015-11-26 16:39 ` Uwe Kleine-König
2015-11-26 23:28 ` Harald Geyer
2015-11-27 10:02 ` Uwe Kleine-König
2015-11-27 10:44 ` Uwe Kleine-König
2015-11-29 10:41 ` Harald Geyer
2015-11-29 11:41 ` Uwe Kleine-König
2015-11-27 14:45 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003164735.GF2694@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=harald@ccbib.org \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.