Re: [PATCH 04/10] staging: wilc1000: replace PRINT_ER with pr_err

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Oct 02, 2015 at 09:44:50PM +0900, Chaehyun Lim wrote:
> This patch replaces PRINT_ER with pr_err.
> It would be better to use netdev_err, but it cannot use it in this
> function, so just use pr_err.
> 
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 566e618..802d87a 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -5322,7 +5322,7 @@ int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *hWFIDrv, u8 u8ChNum)
>  	struct host_if_msg msg;
>  
>  	if (!pstrWFIDrv) {
> -		PRINT_ER("driver is null\n");
> +		pr_err("driver is null\n");
>  		return -EFAULT;
>  	}

I don't see how this check will ever trigger, do you?  If not, it should
just be removed.


>  
> @@ -5334,7 +5334,7 @@ int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *hWFIDrv, u8 u8ChNum)
>  
>  	result = wilc_mq_send(&gMsgQHostIF, &msg, sizeof(struct host_if_msg));
>  	if (result) {
> -		PRINT_ER("wilc mq send fail\n");
> +		pr_err("wilc mq send fail\n");

You should have a network device pointer somewhere here, dig around, it
should be possible to use netdev_err().

thanks,

greg k-h