From: Greg KH <gregkh@linuxfoundation.org>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, chris.park@atmel.com,
tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 09/10] staging: wilc1000: use pr_err in host_int_wait_msg_queue_idle
Date: Sun, 4 Oct 2015 09:42:29 +0100 [thread overview]
Message-ID: <20151004084229.GC21313@kroah.com> (raw)
In-Reply-To: <1443789896-7082-9-git-send-email-chaehyun.lim@gmail.com>
On Fri, Oct 02, 2015 at 09:44:55PM +0900, Chaehyun Lim wrote:
> This patch changes PRINT_ER by pr_err.
> It would be better to use netdev_err, but it cannot use it in this
> function, so just use pr_err.
>
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 69a4e79..79014ab 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -5354,7 +5354,7 @@ int host_int_wait_msg_queue_idle(void)
> msg.id = HOST_IF_MSG_Q_IDLE;
> result = wilc_mq_send(&gMsgQHostIF, &msg, sizeof(struct host_if_msg));
> if (result) {
> - PRINT_ER("wilc mq send fail\n");
> + pr_err("wilc mq send fail\n");
Same as before, you should be able to get to a network device, please
use netdev_err().
next prev parent reply other threads:[~2015-10-04 8:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 12:44 [PATCH 01/10] staging: wilc1000: fix return type of host_int_set_mac_chnl_num Chaehyun Lim
2015-10-02 12:44 ` [PATCH 02/10] staging: wilc1000: fix NULL comparison style Chaehyun Lim
2015-10-02 12:44 ` [PATCH 03/10] staging: wilc1000: rename s32Error in host_int_set_mac_chnl_num Chaehyun Lim
2015-10-04 23:50 ` Julian Calaby
2015-10-02 12:44 ` [PATCH 04/10] staging: wilc1000: replace PRINT_ER with pr_err Chaehyun Lim
2015-10-04 8:40 ` Greg KH
2015-10-02 12:44 ` [PATCH 05/10] staging: wilc1000: rename u8ChNum of host_int_set_mac_chnl_num Chaehyun Lim
2015-10-02 12:44 ` [PATCH 06/10] staging: wilc1000: rename hWFIDrv " Chaehyun Lim
2015-10-04 8:41 ` Greg KH
2015-10-02 12:44 ` [PATCH 07/10] staging: wilc1000: fix return type of host_int_wait_msg_queue_idle Chaehyun Lim
2015-10-02 12:44 ` [PATCH 08/10] staging: wilc1000: rename s32Error in host_int_wait_msg_queue_idle Chaehyun Lim
2015-10-04 23:51 ` Julian Calaby
2015-10-02 12:44 ` [PATCH 09/10] staging: wilc1000: use pr_err " Chaehyun Lim
2015-10-04 8:42 ` Greg KH [this message]
2015-10-02 12:44 ` [PATCH 10/10] staging: wilc1000: remove blank lines before close brace Chaehyun Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004084229.GC21313@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.