* [PATCH v2] Staging: sm750fb: Remove space before paranthesis
@ 2015-10-04 9:42 Amitoj Kaur Chawla
2015-10-04 10:14 ` [Outreachy kernel] " Greg KH
2015-10-04 10:16 ` Julia Lawall
0 siblings, 2 replies; 3+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-04 9:42 UTC (permalink / raw)
To: outreachy-kernel
Remove space before paranthesis ')'. Problem found using
checkpatch.pl
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
- Correct the commit message
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 1683b3d..665238c 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -268,7 +268,7 @@ int ddk750_initHw(initchip_param_t *pInitParam)
#endif
- if (pInitParam->powerMode != 0 )
+ if (pInitParam->powerMode != 0)
pInitParam->powerMode = 0;
setPowerMode(pInitParam->powerMode);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH v2] Staging: sm750fb: Remove space before paranthesis
2015-10-04 9:42 [PATCH v2] Staging: sm750fb: Remove space before paranthesis Amitoj Kaur Chawla
@ 2015-10-04 10:14 ` Greg KH
2015-10-04 10:16 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-10-04 10:14 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: outreachy-kernel
On Sun, Oct 04, 2015 at 03:12:42PM +0530, Amitoj Kaur Chawla wrote:
> Remove space before paranthesis ')'. Problem found using
> checkpatch.pl
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
> - Correct the commit message
You just sent v2 _before_ you sent v1?
And both of them don't apply to my tree, what is going on here?
totally confused,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] Staging: sm750fb: Remove space before paranthesis
2015-10-04 9:42 [PATCH v2] Staging: sm750fb: Remove space before paranthesis Amitoj Kaur Chawla
2015-10-04 10:14 ` [Outreachy kernel] " Greg KH
@ 2015-10-04 10:16 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2015-10-04 10:16 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: outreachy-kernel
On Sun, 4 Oct 2015, Amitoj Kaur Chawla wrote:
> Remove space before paranthesis ')'. Problem found using
> checkpatch.pl
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
> - Correct the commit message
Looks better, thanks.
julia
>
> drivers/staging/sm750fb/ddk750_chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 1683b3d..665238c 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -268,7 +268,7 @@ int ddk750_initHw(initchip_param_t *pInitParam)
> #endif
>
>
> - if (pInitParam->powerMode != 0 )
> + if (pInitParam->powerMode != 0)
> pInitParam->powerMode = 0;
> setPowerMode(pInitParam->powerMode);
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151004094242.GA4089%40amitoj-Inspiron-3542.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-04 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-04 9:42 [PATCH v2] Staging: sm750fb: Remove space before paranthesis Amitoj Kaur Chawla
2015-10-04 10:14 ` [Outreachy kernel] " Greg KH
2015-10-04 10:16 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.