[PATCH] Staging: lustre: obdclass: Remove unused function obd_export_nid2str

[PATCH] Staging: lustre: obdclass: Remove unused function obd_export_nid2str

[Shraddha Barke]

Remove obd_export_nid2str as it is defined but not used anymore.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/lustre/lustre/obdclass/genops.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/genops.c b/drivers/staging/lustre/lustre/obdclass/genops.c
index fbf216b..e0b8150 100644
--- a/drivers/staging/lustre/lustre/obdclass/genops.c
+++ b/drivers/staging/lustre/lustre/obdclass/genops.c
@@ -1104,14 +1104,6 @@ void class_fail_export(struct obd_export *exp)
 }
 EXPORT_SYMBOL(class_fail_export);
 
-static char *obd_export_nid2str(struct obd_export *exp)
-{
-	if (exp->exp_connection != NULL)
-		return libcfs_nid2str(exp->exp_connection->c_peer.nid);
-
-	return "(no nid)";
-}
-
 #if LUSTRE_TRACKS_LOCK_EXP_REFS
 void (*class_export_dump_hook)(struct obd_export *) = NULL;
 EXPORT_SYMBOL(class_export_dump_hook);
-- 
2.1.4

Re: [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Remove unused function obd_export_nid2str

[Julia Lawall]

On Sun, 4 Oct 2015, Shraddha Barke wrote:

> Remove obd_export_nid2str as it is defined but not used anymore.

I think this is on top of your previous patch.  It should be on top of 
Greg's tree, since I guess he won't take a patch that causes build 
warnings.

julia

> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/genops.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/genops.c b/drivers/staging/lustre/lustre/obdclass/genops.c
> index fbf216b..e0b8150 100644
> --- a/drivers/staging/lustre/lustre/obdclass/genops.c
> +++ b/drivers/staging/lustre/lustre/obdclass/genops.c
> @@ -1104,14 +1104,6 @@ void class_fail_export(struct obd_export *exp)
>  }
>  EXPORT_SYMBOL(class_fail_export);
>  
> -static char *obd_export_nid2str(struct obd_export *exp)
> -{
> -	if (exp->exp_connection != NULL)
> -		return libcfs_nid2str(exp->exp_connection->c_peer.nid);
> -
> -	return "(no nid)";
> -}
> -
>  #if LUSTRE_TRACKS_LOCK_EXP_REFS
>  void (*class_export_dump_hook)(struct obd_export *) = NULL;
>  EXPORT_SYMBOL(class_export_dump_hook);
> -- 
> 2.1.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1443950881-25330-1-git-send-email-shraddha.6596%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Remove unused function obd_export_nid2str

[Greg KH]

On Sun, Oct 04, 2015 at 12:09:19PM +0200, Julia Lawall wrote:
> On Sun, 4 Oct 2015, Shraddha Barke wrote:
> 
> > Remove obd_export_nid2str as it is defined but not used anymore.
> 
> I think this is on top of your previous patch.  It should be on top of 
> Greg's tree, since I guess he won't take a patch that causes build 
> warnings.

No, it's ok, I noticed the build warnings after I applied it, and it was
due to patches from a different developer that I accepted, not this
series, from what I can tell, so I let it go in.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Remove unused function obd_export_nid2str

[Greg KH]

On Sun, Oct 04, 2015 at 02:58:01PM +0530, Shraddha Barke wrote:
> Remove obd_export_nid2str as it is defined but not used anymore.
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/genops.c | 8 --------
>  1 file changed, 8 deletions(-)

Thanks, now applied.

I beat the 0-day bot telling you about this for once! :)

greg k-h