From: Greg KH <gregkh@linuxfoundation.org>
To: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/24] ver_linux: echo.patch
Date: Sun, 4 Oct 2015 17:10:16 +0100 [thread overview]
Message-ID: <20151004161016.GA24058@kroah.com> (raw)
In-Reply-To: <CAJ1xhMV8uE2KJt4=V9Mp4dP__w3CO28=61KD9GpX3bFqSQTEmA@mail.gmail.com>
Your subject is really "odd", it doesn't really describe what you are
doing in a single line, it just has a file name in it :(
What did you use to generate these? I got a few duplicates, and there
isn't a "leading" 0 for the first 9 patches. git can spit these out
correctly very simply, I recommend using that in the future.
On Sat, Oct 03, 2015 at 03:57:08PM +0300, Alexander Kapshuk wrote:
> While not a problem in itself, I was not sure why 'echo space' was used.
> Not being aware of any immediate benefits to this, I thought using
> 'echo' by itself would suffice in printing a newline, which I believe is
> the desired behaviour.
>
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
> --- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300
> +++ linux/scripts/ver_linux 2015-10-03 13:43:38.587271851 +0300
> @@ -6,10 +6,10 @@
> #
> echo 'If some fields are empty or look unusual you may have an old version.'
> echo 'Compare to the current minimal requirements in Documentation/Changes.'
> -echo ' '
> +echo
>
> uname -a
> -echo ' '
> +echo
Can you respin these patches with correct subject lines, based on this,
and the other feedback you have gotten and resend them?
thanks,
greg k-h
prev parent reply other threads:[~2015-10-04 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 12:57 [PATCH 1/24] ver_linux: echo.patch Alexander Kapshuk
2015-10-04 16:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004161016.GA24058@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.kapshuk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.