From: Davidlohr Bueso <dave@stgolabs.net>
To: Geliang Tang <geliangtang@163.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Joonsoo Kim <js1304@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Leon Romanovsky <leon@leon.nu>, Oleg Nesterov <oleg@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()
Date: Sun, 4 Oct 2015 18:50:55 -0700 [thread overview]
Message-ID: <20151005015055.GA8831@linux-uzut.site> (raw)
In-Reply-To: <45bf632d263280847a2a894017c62b7f2a71eda1.1443937856.git.geliangtang@163.com>
On Sun, 04 Oct 2015, Geliang Tang wrote:
>BUG_ON() already contain an unlikely compiler flag. Drop it.
>
>Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
... but I believe you do have some left:
drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > ivecs));
drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > queue_max_integrity_segments(rq->q)));
kernel/sched/core.c: BUG_ON(unlikely(task_stack_end_corrupted(prev)));
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Davidlohr Bueso <dave@stgolabs.net>
To: Geliang Tang <geliangtang@163.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Joonsoo Kim <js1304@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Leon Romanovsky <leon@leon.nu>, Oleg Nesterov <oleg@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()
Date: Sun, 4 Oct 2015 18:50:55 -0700 [thread overview]
Message-ID: <20151005015055.GA8831@linux-uzut.site> (raw)
In-Reply-To: <45bf632d263280847a2a894017c62b7f2a71eda1.1443937856.git.geliangtang@163.com>
On Sun, 04 Oct 2015, Geliang Tang wrote:
>BUG_ON() already contain an unlikely compiler flag. Drop it.
>
>Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
... but I believe you do have some left:
drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > ivecs));
drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > queue_max_integrity_segments(rq->q)));
kernel/sched/core.c: BUG_ON(unlikely(task_stack_end_corrupted(prev)));
next prev parent reply other threads:[~2015-10-05 1:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 6:18 [PATCH 1/3] scsi: drop unlikely behind BUG_ON() Geliang Tang
2015-10-04 6:18 ` [PATCH 2/3] sched/core: " Geliang Tang
2015-10-04 6:18 ` [PATCH 3/3] mm/nommu: " Geliang Tang
2015-10-04 6:18 ` Geliang Tang
2015-10-04 11:02 ` Leon Romanovsky
2015-10-04 11:02 ` Leon Romanovsky
2015-10-05 2:04 ` Davidlohr Bueso
2015-10-05 2:04 ` Davidlohr Bueso
2015-10-05 7:49 ` Leon Romanovsky
2015-10-05 7:49 ` Leon Romanovsky
2015-10-05 1:50 ` Davidlohr Bueso [this message]
2015-10-05 1:50 ` Davidlohr Bueso
2015-10-05 2:30 ` Geliang Tang
2015-10-05 2:30 ` Geliang Tang
2015-10-05 3:37 ` Davidlohr Bueso
2015-10-05 3:37 ` Davidlohr Bueso
2015-10-04 14:33 ` [PATCH 1/3] scsi: " Bart Van Assche
2015-10-04 14:33 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005015055.GA8831@linux-uzut.site \
--to=dave@stgolabs.net \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=geliangtang@163.com \
--cc=hughd@google.com \
--cc=js1304@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=leon@leon.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.