Re: [Outreachy kernel] [PATCH] Staging: most: Use module_platform_driver

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Oct 04, 2015 at 09:47:16PM +0200, Arnd Bergmann wrote:
> On Sunday 04 October 2015 20:41:44 Greg KH wrote:
> > On Sun, Oct 04, 2015 at 09:30:50PM +0200, Arnd Bergmann wrote:
> > > On Saturday 03 October 2015 17:31:30 Shraddha Barke wrote:
> > > > 
> > > > -/**
> > > > - * dim2_hdm_init - Driver Registration Routine
> > > > - */
> > > > -static int __init dim2_hdm_init(void)
> > > > -{
> > > > -       pr_info("dim2_hdm_init()\n");
> > > > -       return platform_driver_register(&dim2_driver);
> > > > -}
> > > > -
> > > > 
> > > 
> > > Your changelog does not mention that you are removing the pr_info() lines
> > > in the process of the conversion.
> > > 
> > > Removing those lines is a good idea, but that should better be done as
> > > a separate patch upfront, possibly removing other debug statements
> > > from the same driver as well.
> > 
> > No, this is how we converted all of the other drivers to this api a long
> > time ago, no need to break it up into 2 patches.  This is also one of
> > the main reasons to use this api, to keep things "quiet".
> > 
> 
> Ok, fair enough. It's probably worth mentioning that in the changelog though.

I don't think I ever did that when I converted drivers to this api, so I
wouldn't expect a new developer to do something I wasn't willing to do
:)

thanks,

greg k-h