From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Shraddha Barke <shraddha.6596@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: most: Use module_platform_driver
Date: Sun, 04 Oct 2015 21:30:50 +0200 [thread overview]
Message-ID: <6498111.CeIiP0D2Ox@wuerfel> (raw)
In-Reply-To: <1443873690-30847-1-git-send-email-shraddha.6596@gmail.com>
On Saturday 03 October 2015 17:31:30 Shraddha Barke wrote:
>
> -/**
> - * dim2_hdm_init - Driver Registration Routine
> - */
> -static int __init dim2_hdm_init(void)
> -{
> - pr_info("dim2_hdm_init()\n");
> - return platform_driver_register(&dim2_driver);
> -}
> -
>
Your changelog does not mention that you are removing the pr_info() lines
in the process of the conversion.
Removing those lines is a good idea, but that should better be done as
a separate patch upfront, possibly removing other debug statements
from the same driver as well.
Arnd
next prev parent reply other threads:[~2015-10-04 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 12:01 [PATCH] Staging: most: Use module_platform_driver Shraddha Barke
2015-10-04 19:30 ` Arnd Bergmann [this message]
[not found] ` <20151004194144.GA23542@kroah.com>
2015-10-04 19:47 ` [Outreachy kernel] " Arnd Bergmann
2015-10-05 3:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6498111.CeIiP0D2Ox@wuerfel \
--to=arnd@arndb.de \
--cc=outreachy-kernel@googlegroups.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.