All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>, John Stultz <john.stultz@linaro.org>,
	tglx@linutronix.de,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Linux ARM Kernel Mailing List
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC/PATCH 09/11] clocksource: add TI 32.768 Hz counter driver
Date: Mon, 5 Oct 2015 04:03:36 -0700	[thread overview]
Message-ID: <20151005110336.GX23801@atomide.com> (raw)
In-Reply-To: <20151005105034.GU23801@atomide.com>

* Tony Lindgren <tony@atomide.com> [151005 03:56]:
> * Daniel Lezcano <daniel.lezcano@linaro.org> [151001 15:04]:
> > >+	clocks_calc_mult_shift(&persistent_mult, &persistent_shift,
> > >+			32768, NSEC_PER_SEC, 120000);
> > >+
> > >+	ret = clocksource_mmio_init(sync32k_cnt_reg, "32k_counter", 32768,
> > >+				250, 32, clocksource_mmio_readl_up);
> > >+	if (ret) {
> > >+		pr_err("32k_counter: can't register clocksource\n");
> > >+		return;
> > >+	}
> > >+
> > >+	sched_clock_register(omap_32k_read_sched_clock, 32, 32768);
> > >+	register_persistent_clock(NULL, omap_read_persistent_clock64);
> > 
> > I will let John Stultz to have a look at this part because I have doubt
> > regarding the usage of the persistent clock.
> 
> The persistent clock we want to keep for deeper idle states..
> Especially when we start changing clocksource for the duration of
> deeper idle states. I'll post some updated patches on that when I
> get a chance.

But sounds like we can just have read_persistent_clock() check
for the CLOCK_SOURCE_SUSPEND_NONSTOP like I pointed in the other
patch in this series.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 09/11] clocksource: add TI 32.768 Hz counter driver
Date: Mon, 5 Oct 2015 04:03:36 -0700	[thread overview]
Message-ID: <20151005110336.GX23801@atomide.com> (raw)
In-Reply-To: <20151005105034.GU23801@atomide.com>

* Tony Lindgren <tony@atomide.com> [151005 03:56]:
> * Daniel Lezcano <daniel.lezcano@linaro.org> [151001 15:04]:
> > >+	clocks_calc_mult_shift(&persistent_mult, &persistent_shift,
> > >+			32768, NSEC_PER_SEC, 120000);
> > >+
> > >+	ret = clocksource_mmio_init(sync32k_cnt_reg, "32k_counter", 32768,
> > >+				250, 32, clocksource_mmio_readl_up);
> > >+	if (ret) {
> > >+		pr_err("32k_counter: can't register clocksource\n");
> > >+		return;
> > >+	}
> > >+
> > >+	sched_clock_register(omap_32k_read_sched_clock, 32, 32768);
> > >+	register_persistent_clock(NULL, omap_read_persistent_clock64);
> > 
> > I will let John Stultz to have a look at this part because I have doubt
> > regarding the usage of the persistent clock.
> 
> The persistent clock we want to keep for deeper idle states..
> Especially when we start changing clocksource for the duration of
> deeper idle states. I'll post some updated patches on that when I
> get a chance.

But sounds like we can just have read_persistent_clock() check
for the CLOCK_SOURCE_SUSPEND_NONSTOP like I pointed in the other
patch in this series.

Tony

  reply	other threads:[~2015-10-05 11:03 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 20:43 [RFC/PATCH 00/11] arm: omap: counter32k rework Felipe Balbi
2015-09-29 20:43 ` Felipe Balbi
2015-09-29 20:43 ` Felipe Balbi
2015-09-29 20:43 ` [RFC/PATCH 01/11] arm: omap2: timer: get rid of obfuscating macros Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-09-29 20:43 ` [RFC/PATCH 02/11] arm: omap2: timer: add a gptimer argument to sync32k_timer_init() Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-09-29 20:43 ` [RFC/PATCH 03/11] arm: omap2: timer: remove __omap_gptimer_init() Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-10-05 11:01   ` Tony Lindgren
2015-10-05 11:01     ` Tony Lindgren
2015-10-05 15:24     ` Felipe Balbi
2015-10-05 15:24       ` Felipe Balbi
2015-10-05 15:24       ` Felipe Balbi
2015-10-05 16:02       ` Tony Lindgren
2015-10-05 16:02         ` Tony Lindgren
2015-10-05 16:08         ` Felipe Balbi
2015-10-05 16:08           ` Felipe Balbi
2015-10-05 16:08           ` Felipe Balbi
2015-10-05 16:30           ` Tony Lindgren
2015-10-05 16:30             ` Tony Lindgren
2015-09-29 20:43 ` [RFC/PATCH 04/11] arm: omap2: timer: provide generic sync32k_timer_init function Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-09-29 20:43   ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 05/11] arm: omap2: timer: move realtime_counter_init() around Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 06/11] arm: omap2: timer: always call clocksource_of_init() when DT Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 07/11] arm: omap2: timer: remove omap4_local_timer_init Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 08/11] arm: omap2: timer: rename omap_sync32k_timer_init() Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 09/11] clocksource: add TI 32.768 Hz counter driver Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-10-01 21:58   ` John Stultz
2015-10-01 21:58     ` John Stultz
2015-10-01 21:59   ` Daniel Lezcano
2015-10-01 21:59     ` Daniel Lezcano
2015-10-05 10:50     ` Tony Lindgren
2015-10-05 10:50       ` Tony Lindgren
2015-10-05 11:03       ` Tony Lindgren [this message]
2015-10-05 11:03         ` Tony Lindgren
2015-10-01 22:20   ` John Stultz
2015-10-01 22:20     ` John Stultz
2015-10-01 22:30     ` Felipe Balbi
2015-10-01 22:30       ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 10/11] arm: omap2: timer: limit hwmod usage to non-DT boots Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-29 20:44   ` Felipe Balbi
2015-09-30  8:15   ` Arnd Bergmann
2015-09-30  8:15     ` Arnd Bergmann
2015-09-30 14:12     ` Felipe Balbi
2015-09-30 14:12       ` Felipe Balbi
2015-09-30 14:12       ` Felipe Balbi
2015-09-30 21:58       ` Arnd Bergmann
2015-09-30 21:58         ` Arnd Bergmann
2015-10-05 17:52         ` Felipe Balbi
2015-10-05 17:52           ` Felipe Balbi
2015-10-05 17:52           ` Felipe Balbi
2015-10-05 19:41           ` Felipe Balbi
2015-10-05 19:41             ` Felipe Balbi
2015-10-05 19:41             ` Felipe Balbi
2015-10-06  8:08             ` Arnd Bergmann
2015-10-06  8:08               ` Arnd Bergmann
2015-10-06 14:57               ` Felipe Balbi
2015-10-06 14:57                 ` Felipe Balbi
2015-10-06 14:57                 ` Felipe Balbi
2015-10-06 15:18                 ` Tony Lindgren
2015-10-06 15:18                   ` Tony Lindgren
2015-10-06 15:29                   ` Felipe Balbi
2015-10-06 15:29                     ` Felipe Balbi
2015-10-06 15:29                     ` Felipe Balbi
2015-10-05 10:45   ` Tony Lindgren
2015-10-05 10:45     ` Tony Lindgren
2015-09-30  8:22 ` [RFC/PATCH 00/11] arm: omap: counter32k rework Arnd Bergmann
2015-09-30  8:22   ` Arnd Bergmann
2015-09-30 14:13   ` Felipe Balbi
2015-09-30 14:13     ` Felipe Balbi
2015-09-30 14:13     ` Felipe Balbi
     [not found]     ` <20150930141338.GC31865-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-09-30 14:42       ` Arnd Bergmann
2015-09-30 14:42         ` Arnd Bergmann
2015-09-30 14:42         ` Arnd Bergmann
2015-09-30 14:49         ` Arnd Bergmann
2015-09-30 14:49           ` Arnd Bergmann
2015-09-30 14:49           ` Arnd Bergmann
2015-09-30 14:57           ` Felipe Balbi
2015-09-30 14:57             ` Felipe Balbi
2015-09-30 14:57             ` Felipe Balbi
2015-09-30 15:03           ` Thierry Reding
2015-09-30 15:03             ` Thierry Reding
2015-09-30 15:03             ` Thierry Reding
2015-10-01 22:12           ` Daniel Lezcano
2015-10-01 22:12             ` Daniel Lezcano
2015-10-01 22:12             ` Daniel Lezcano
     [not found]             ` <560DAFC5.50003-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-05 10:55               ` Tony Lindgren
2015-10-05 10:55                 ` Tony Lindgren
2015-10-05 10:55                 ` Tony Lindgren
     [not found]                 ` <20151005105554.GV23801-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-10-05 11:03                   ` Arnd Bergmann
2015-10-05 11:03                     ` Arnd Bergmann
2015-10-05 11:03                     ` Arnd Bergmann
2015-10-05 11:13                     ` Tony Lindgren
2015-10-05 11:13                       ` Tony Lindgren
2015-10-05 11:13                       ` Tony Lindgren
     [not found]                       ` <20151005111341.GY23801-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-10-05 12:19                         ` Arnd Bergmann
2015-10-05 12:19                           ` Arnd Bergmann
2015-10-05 12:19                           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005110336.GX23801@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.