From: Chris Mason <clm@fb.com>
To: Neil Brown <neilb@suse.de>
Cc: <dsterba@suse.cz>, Josef Bacik <jbacik@fb.com>,
Jan Kara <jack@suse.cz>,
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
<linux-fsdevel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
<linux-nilfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] BTRFS: support NFSv2 export
Date: Mon, 5 Oct 2015 10:32:46 -0400 [thread overview]
Message-ID: <20151005143246.GW25218@ret.masoncoding.com> (raw)
In-Reply-To: <87r3lowpax.fsf@notabene.neil.brown.name>
On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote:
> David Sterba <dsterba@suse.cz> writes:
>
> > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote:
> >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as
> >> that returned by encode_fh - it may be larger.
> >>
> >> With NFSv2, the filehandle is fixed length, so it may appear longer
> >> than expected and be zero-padded.
> >>
> >> So we must test that fh_len is at least some value, not exactly equal
> >> to it.
> >>
> >> Signed-off-by: NeilBrown <neilb@suse.de>
> >
> > Acked-by: David Sterba <dsterba@suse.cz>
>
> Thanks. However I just checked mainline and this still hasn't been
> applied.
> Should I resend it to someone? Who?
Sorry Neil, I thought you were pushing these after it was ack'd. I'll
put it in my pull this week.
-chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <clm@fb.com>
To: Neil Brown <neilb@suse.de>
Cc: dsterba@suse.cz, Josef Bacik <jbacik@fb.com>,
Jan Kara <jack@suse.cz>,
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] BTRFS: support NFSv2 export
Date: Mon, 5 Oct 2015 10:32:46 -0400 [thread overview]
Message-ID: <20151005143246.GW25218@ret.masoncoding.com> (raw)
In-Reply-To: <87r3lowpax.fsf@notabene.neil.brown.name>
On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote:
> David Sterba <dsterba@suse.cz> writes:
>
> > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote:
> >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as
> >> that returned by encode_fh - it may be larger.
> >>
> >> With NFSv2, the filehandle is fixed length, so it may appear longer
> >> than expected and be zero-padded.
> >>
> >> So we must test that fh_len is at least some value, not exactly equal
> >> to it.
> >>
> >> Signed-off-by: NeilBrown <neilb@suse.de>
> >
> > Acked-by: David Sterba <dsterba@suse.cz>
>
> Thanks. However I just checked mainline and this still hasn't been
> applied.
> Should I resend it to someone? Who?
Sorry Neil, I thought you were pushing these after it was ack'd. I'll
put it in my pull this week.
-chris
next prev parent reply other threads:[~2015-10-05 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 0:16 [PATCH 0/3] make BTRFS, UDF, NILFS2 work with NFSv2 NeilBrown
2015-05-08 0:16 ` [PATCH 2/3] NILFS2: support NFSv2 export NeilBrown
2015-05-10 16:31 ` Ryusuke Konishi
2015-05-10 16:31 ` Ryusuke Konishi
2015-05-11 7:02 ` NeilBrown
2015-05-11 9:54 ` Ryusuke Konishi
2015-05-11 11:13 ` [PATCH v2] " NeilBrown
2015-05-08 0:16 ` [PATCH 3/3] UDF: " NeilBrown
2015-05-11 8:57 ` Jan Kara
2015-05-11 8:57 ` Jan Kara
2015-05-08 0:16 ` [PATCH 1/3] BTRFS: " NeilBrown
2015-05-08 0:16 ` NeilBrown
2015-05-11 8:13 ` David Sterba
2015-09-24 1:59 ` Neil Brown
2015-10-05 14:32 ` Chris Mason [this message]
2015-10-05 14:32 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005143246.GW25218@ret.masoncoding.com \
--to=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.