[PATCH] Staging: lustre: lnet: klnds: socklnd: removed trailing whitespace

[PATCH] Staging: lustre: lnet: klnds: socklnd: removed trailing whitespace

[Hatice ERTÜRK]

Removed all trailing whitespace in
"staging/lustre/lnet/klnds/socklnd/socklnd.c"

Signed-off-by: Hatice ERTÜRK <haticeerturk27@gmail.com>
---
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
index d5268e9..2a06f53 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
@@ -228,7 +228,7 @@ ksocknal_unlink_peer_locked(ksock_peer_t *peer)
 		ip = peer->ksnp_passive_ips[i];
 
 		iface = ksocknal_ip2iface(peer->ksnp_ni, ip);
-		/* 
+		/*
 		 * All IPs in peer->ksnp_passive_ips[] come from the
 		 * interface list, therefore the call must succeed.
 		 */
@@ -362,7 +362,7 @@ ksocknal_associate_route_conn_locked(ksock_route_t *route, ksock_conn_t *conn)
 	route->ksnr_connected |= (1<<type);
 	route->ksnr_conn_count++;
 
-	/* 
+	/*
 	 * Successful connection => further attempts can
 	 * proceed immediately
 	 */
@@ -444,7 +444,7 @@ ksocknal_del_route_locked(ksock_route_t *route)
 
 	if (list_empty(&peer->ksnp_routes) &&
 	    list_empty(&peer->ksnp_conns)) {
-		/* 
+		/*
 		 * I've just removed the last route to a peer with no active
 		 * connections
 		 */
@@ -547,7 +547,7 @@ ksocknal_del_peer_locked(ksock_peer_t *peer, __u32 ip)
 	}
 
 	if (nshared == 0) {
-		/* 
+		/*
 		 * remove everything else if there are no explicit entries
 		 * left
 		 */
@@ -702,7 +702,7 @@ ksocknal_local_ipvec(lnet_ni_t *ni, __u32 *ipaddrs)
 	nip = net->ksnn_ninterfaces;
 	LASSERT(nip <= LNET_MAX_INTERFACES);
 
-	/* 
+	/*
 	 * Only offer interfaces for additional connections if I have
 	 * more than one.
 	 */
@@ -769,7 +769,7 @@ ksocknal_select_ips(ksock_peer_t *peer, __u32 *peerips, int n_peerips)
 	int best_netmatch;
 	int best_npeers;
 
-	/* 
+	/*
 	 * CAVEAT EMPTOR: We do all our interface matching with an
 	 * exclusive hold of global lock at IRQ priority.  We're only
 	 * expecting to be dealing with small numbers of interfaces, so the
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: lustre: lnet: klnds: socklnd: removed trailing whitespace

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2943 bytes --]

On Mon, 5 Oct 2015, Hatice ERTÜRK wrote:

> Removed all trailing whitespace in
> "staging/lustre/lnet/klnds/socklnd/socklnd.c"

You don't have to redo it, but it's not necessary to put the whole name of
the file.  One can see it just below in the diffstat.

julia

> Signed-off-by: Hatice ERTÜRK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> index d5268e9..2a06f53 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> @@ -228,7 +228,7 @@ ksocknal_unlink_peer_locked(ksock_peer_t *peer)
>  		ip = peer->ksnp_passive_ips[i];
>
>  		iface = ksocknal_ip2iface(peer->ksnp_ni, ip);
> -		/*
> +		/*
>  		 * All IPs in peer->ksnp_passive_ips[] come from the
>  		 * interface list, therefore the call must succeed.
>  		 */
> @@ -362,7 +362,7 @@ ksocknal_associate_route_conn_locked(ksock_route_t *route, ksock_conn_t *conn)
>  	route->ksnr_connected |= (1<<type);
>  	route->ksnr_conn_count++;
>
> -	/*
> +	/*
>  	 * Successful connection => further attempts can
>  	 * proceed immediately
>  	 */
> @@ -444,7 +444,7 @@ ksocknal_del_route_locked(ksock_route_t *route)
>
>  	if (list_empty(&peer->ksnp_routes) &&
>  	    list_empty(&peer->ksnp_conns)) {
> -		/*
> +		/*
>  		 * I've just removed the last route to a peer with no active
>  		 * connections
>  		 */
> @@ -547,7 +547,7 @@ ksocknal_del_peer_locked(ksock_peer_t *peer, __u32 ip)
>  	}
>
>  	if (nshared == 0) {
> -		/*
> +		/*
>  		 * remove everything else if there are no explicit entries
>  		 * left
>  		 */
> @@ -702,7 +702,7 @@ ksocknal_local_ipvec(lnet_ni_t *ni, __u32 *ipaddrs)
>  	nip = net->ksnn_ninterfaces;
>  	LASSERT(nip <= LNET_MAX_INTERFACES);
>
> -	/*
> +	/*
>  	 * Only offer interfaces for additional connections if I have
>  	 * more than one.
>  	 */
> @@ -769,7 +769,7 @@ ksocknal_select_ips(ksock_peer_t *peer, __u32 *peerips, int n_peerips)
>  	int best_netmatch;
>  	int best_npeers;
>
> -	/*
> +	/*
>  	 * CAVEAT EMPTOR: We do all our interface matching with an
>  	 * exclusive hold of global lock at IRQ priority.  We're only
>  	 * expecting to be dealing with small numbers of interfaces, so the
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1444074576-12447-1-git-send-email-haticeerturk27%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: lustre: lnet: klnds: socklnd: removed trailing whitespace

[Arnd Bergmann]

On Monday 05 October 2015 21:32:53 Julia Lawall wrote:
> On Mon, 5 Oct 2015, Hatice ERTÜRK wrote:
> 
> > Removed all trailing whitespace in
> > "staging/lustre/lnet/klnds/socklnd/socklnd.c"
> 
> You don't have to redo it, but it's not necessary to put the whole name of
> the file.  One can see it just below in the diffstat.

Right. Similarly for the subject line, there are lots of ways
to write this but using five keywords seems excessive. I would
probably write this as

"staging/lustre: socklnd: removed trailing whitespace"

	Arnd

Re: [Outreachy kernel] [PATCH] Staging: lustre: lnet: klnds: socklnd: removed trailing whitespace

[Sudip Mukherjee]

On Mon, Oct 05, 2015 at 10:49:36PM +0300, Hatice ERT�RK wrote:
> Removed all trailing whitespace in
> "staging/lustre/lnet/klnds/socklnd/socklnd.c"
> 
> Signed-off-by: Hatice ERT�RK <haticeerturk27@gmail.com>
> ---
OOPS .. no.. these trailing whitespaces were introduced by your previous
patch. We dont have these trailing whitespaces in staging tree.

regards
sudip