All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ
Date: Tue, 6 Oct 2015 10:37:19 +0100	[thread overview]
Message-ID: <20151006093718.GA30154@localhost> (raw)
In-Reply-To: <5022096.8QRzW0l3EJ@wuerfel>

On Tue, Oct 06, 2015 at 09:49:29AM +0200, Arnd Bergmann wrote:
> On Tuesday 06 October 2015 11:05:43 Manjeet Pawar wrote:
> > MINSIGSTKSZ and SIGSTKSZ for ARM64 are not correctly set in latest kernel.
> > This patch fixes this issue.
> > 
> > This issue is reported in LTP (testcase: sigaltstack02.c).
> > Testcase failed when sigaltstack() called with stack size "MINSIGSTKSZ - 1"
> > Since in Glibc-2.22, MINSIGSTKSZ is set to 5120 but in kernel
> > it is set to 2048 so testcase gets failed.
> > 
> > Testcase Output:
> > sigaltstack02 1  TPASS  :  stgaltstack() fails, Invalid Flag value,errno:22
> > sigaltstack02 2  TFAIL  :  sigaltstack() returned 0, expected -1,errno:12
> > 
> > Reported Issue in Glibc Bugzilla:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=16850
> > 
> > Bugfix in Glibc-2.22:
> > https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/unix/
> > sysv/linux/aarch64/bits/sigstack.h;h=8f2fb76e3e81734ef8a9cf9ae40daf4705
> > f31c35;hb=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e
> > 
> > Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> > Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
> > Signed-off-by: Rohit Thapliyal <r.thapliyal@samsung.com>
> 
> This looks correct now. A few more points though:
> 
> * My first thought would have been to do this by first defining the
>   two symbols before the #include, and then adding an #ifdef in
>   the generic file. Both approaches work though, any other opinions
>   on this?

That's what I was thinking as well. Maybe with a single #ifndef
MINSIGSTKSZ to cover both macros.

> * Do we need to backport this to stable?

I think it does.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com,
	linux-kernel@vger.kernel.org,
	Akhilesh Kumar <akhilesh.k@samsung.com>,
	Rohit Thapliyal <r.thapliyal@samsung.com>,
	Manjeet Pawar <manjeet.p@samsung.com>,
	pankaj.m@samsung.com
Subject: Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ
Date: Tue, 6 Oct 2015 10:37:19 +0100	[thread overview]
Message-ID: <20151006093718.GA30154@localhost> (raw)
In-Reply-To: <5022096.8QRzW0l3EJ@wuerfel>

On Tue, Oct 06, 2015 at 09:49:29AM +0200, Arnd Bergmann wrote:
> On Tuesday 06 October 2015 11:05:43 Manjeet Pawar wrote:
> > MINSIGSTKSZ and SIGSTKSZ for ARM64 are not correctly set in latest kernel.
> > This patch fixes this issue.
> > 
> > This issue is reported in LTP (testcase: sigaltstack02.c).
> > Testcase failed when sigaltstack() called with stack size "MINSIGSTKSZ - 1"
> > Since in Glibc-2.22, MINSIGSTKSZ is set to 5120 but in kernel
> > it is set to 2048 so testcase gets failed.
> > 
> > Testcase Output:
> > sigaltstack02 1  TPASS  :  stgaltstack() fails, Invalid Flag value,errno:22
> > sigaltstack02 2  TFAIL  :  sigaltstack() returned 0, expected -1,errno:12
> > 
> > Reported Issue in Glibc Bugzilla:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=16850
> > 
> > Bugfix in Glibc-2.22:
> > https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/unix/
> > sysv/linux/aarch64/bits/sigstack.h;h=8f2fb76e3e81734ef8a9cf9ae40daf4705
> > f31c35;hb=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e
> > 
> > Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> > Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
> > Signed-off-by: Rohit Thapliyal <r.thapliyal@samsung.com>
> 
> This looks correct now. A few more points though:
> 
> * My first thought would have been to do this by first defining the
>   two symbols before the #include, and then adding an #ifdef in
>   the generic file. Both approaches work though, any other opinions
>   on this?

That's what I was thinking as well. Maybe with a single #ifndef
MINSIGSTKSZ to cover both macros.

> * Do we need to backport this to stable?

I think it does.

-- 
Catalin

  reply	other threads:[~2015-10-06  9:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06  5:35 [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Manjeet Pawar
2015-10-06  5:35 ` Manjeet Pawar
2015-10-06  7:49 ` Arnd Bergmann
2015-10-06  7:49   ` Arnd Bergmann
2015-10-06  9:37   ` Catalin Marinas [this message]
2015-10-06  9:37     ` Catalin Marinas
2015-10-06 10:31   ` Dave Martin
2015-10-06 10:31     ` Dave Martin
2015-10-06 10:51     ` Arnd Bergmann
2015-10-06 10:51       ` Arnd Bergmann
2015-10-06 10:59       ` Andreas Schwab
2015-10-06 10:59         ` Andreas Schwab
2015-10-06 11:33         ` Dave Martin
2015-10-06 11:33           ` Dave Martin
2015-10-06 11:52           ` Andreas Schwab
2015-10-06 11:52             ` Andreas Schwab
2015-10-06 12:49             ` Dave Martin
2015-10-06 12:49               ` Dave Martin
2015-10-06 11:22       ` Dave Martin
2015-10-06 11:22         ` Dave Martin
2015-10-09  8:41       ` Arnd Bergmann
2015-10-09  8:41         ` Arnd Bergmann
2015-10-12 13:53         ` Dave Martin
2015-10-12 13:53           ` Dave Martin
2015-10-06 10:19 ` Will Deacon
2015-10-06 10:19   ` Will Deacon
  -- strict thread matches above, loose matches on Subject: below --
2015-10-09  8:17 Manjeet Pawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151006093718.GA30154@localhost \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.