From: Christoph Hellwig <hch@lst.de>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map
Date: Tue, 6 Oct 2015 11:43:36 +0200 [thread overview]
Message-ID: <20151006094336.GA29336@lst.de> (raw)
In-Reply-To: <CAC5umygbe7Z4qvKC+rUub8Dfwe8hMnVynYKittO6BNZBmRftsA@mail.gmail.com>
On Tue, Oct 06, 2015 at 08:50:47AM +0900, Akinobu Mita wrote:
> 2015-09-29 15:52 GMT+09:00 Christoph Hellwig <hch@lst.de>:
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> >
> > Can you also add a patch that renames blk_mq_free_queue to
> > blk_mq_cleaup_queue and adds a comment that we should not free any memory
> > here? We had way too many bugs of this kinds unfortunately.
>
> Renaming blk_mq_free_queue to blk_mq_cleaup_queue sounds good because
> it is called from blk_cleanup_queue().
>
> How about adding comment like below?
This looks great. It's a lot more than what I though but it looks correct
and useful!
next prev parent reply other threads:[~2015-10-06 9:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 17:09 [PATCH v4 0/7] blk-mq: fix race conditions on cpu hotplug handling Akinobu Mita
2015-09-26 17:09 ` [PATCH v4 1/7] blk-mq: avoid setting hctx->tags->cpumask before allocation Akinobu Mita
2015-09-26 18:12 ` Christoph Hellwig
2015-09-26 17:09 ` [PATCH v4 2/7] blk-mq: fix sysfs registration/unregistration race Akinobu Mita
2015-09-29 6:51 ` Christoph Hellwig
2015-09-26 17:09 ` [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map Akinobu Mita
2015-09-29 6:52 ` Christoph Hellwig
2015-10-05 23:50 ` Akinobu Mita
2015-10-06 9:43 ` Christoph Hellwig [this message]
2015-09-26 17:09 ` [PATCH v4 4/7] blk-mq: fix q->mq_usage_counter access race Akinobu Mita
2015-09-29 6:53 ` Christoph Hellwig
2015-09-26 17:09 ` [PATCH v4 5/7] blk-mq: avoid inserting requests before establishing new mapping Akinobu Mita
2015-09-29 6:54 ` Christoph Hellwig
2015-09-26 17:09 ` [PATCH v4 6/7] blk-mq: fix freeze queue race Akinobu Mita
2015-09-26 17:32 ` Tejun Heo
2015-09-27 13:06 ` Akinobu Mita
2015-09-28 14:48 ` Tejun Heo
2015-09-29 6:55 ` Christoph Hellwig
2015-09-29 15:01 ` Jens Axboe
2015-09-29 15:03 ` Tejun Heo
2015-09-29 21:50 ` Tejun Heo
2015-09-30 10:32 ` Akinobu Mita
2015-09-26 17:09 ` [PATCH v4 7/7] blk-mq: fix deadlock when reading cpu_list Akinobu Mita
2015-09-29 6:58 ` Christoph Hellwig
2015-09-29 17:31 ` [PATCH v4 0/7] blk-mq: fix race conditions on cpu hotplug handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006094336.GA29336@lst.de \
--to=hch@lst.de \
--cc=akinobu.mita@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.