All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: bp@alien8.de, luto@amacapital.net, peterz@infradead.org,
	sds@tycho.nsa.gov, keescook@chromium.org,
	torvalds@linux-foundation.org, efault@gmx.de,
	linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
	brgerst@gmail.com, dvlasenk@redhat.com,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] x86/mm: Warn on W^X mappings
Date: Tue, 6 Oct 2015 16:49:37 +0200	[thread overview]
Message-ID: <20151006144937.GA15284@gmail.com> (raw)
In-Reply-To: <5613D96C.8080407@linux.intel.com>


* Arjan van de Ven <arjan@linux.intel.com> wrote:

> On 10/6/2015 2:54 AM, tip-bot for Stephen Smalley wrote:
> >Commit-ID:  e1a58320a38dfa72be48a0f1a3a92273663ba6db
> >Gitweb:     http://git.kernel.org/tip/e1a58320a38dfa72be48a0f1a3a92273663ba6db
> >Author:     Stephen Smalley <sds@tycho.nsa.gov>
> >AuthorDate: Mon, 5 Oct 2015 12:55:20 -0400
> >Committer:  Ingo Molnar <mingo@kernel.org>
> >CommitDate: Tue, 6 Oct 2015 11:11:48 +0200
> >
> >x86/mm: Warn on W^X mappings
> >
> >Warn on any residual W+X mappings after setting NX
> >if DEBUG_WX is enabled.  Introduce a separate
> >X86_PTDUMP_CORE config that enables the code for
> >dumping the page tables without enabling the debugfs
> >interface, so that DEBUG_WX can be enabled without
> >exposing the debugfs interface.  Switch EFI_PGT_DUMP
> >to using X86_PTDUMP_CORE so that it also does not require
> >enabling the debugfs interface.
> 
> I like it, so Acked-by: Arjan van de Ven <arjan@Linux.intel.com>
> 
> I also have/had an old userland script to do similar checks but using the 
> debugfs interface... ... would that be useful to have somewhere more central?
> 
> http://git.fenrus.org/tmp/i386-check-pagetables.pl

Sure, I think it could be put into tools/testing/selftests/x86/.

Thanks,

	Ingo

  reply	other threads:[~2015-10-06 14:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 16:55 [PATCH v3] x86/mm: warn on W+x mappings Stephen Smalley
2015-10-05 19:36 ` Kees Cook
2015-10-06  9:54 ` [tip:x86/mm] x86/mm: Warn on W^X mappings tip-bot for Stephen Smalley
2015-10-06 14:23   ` Arjan van de Ven
2015-10-06 14:49     ` Ingo Molnar [this message]
2015-10-08 14:57   ` Borislav Petkov
2015-10-08 15:00     ` Arjan van de Ven
2015-10-08 15:33       ` Borislav Petkov
2015-10-08 18:11         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151006144937.GA15284@gmail.com \
    --to=mingo@kernel.org \
    --cc=arjan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    --cc=sds@tycho.nsa.gov \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.