From: Arjan van de Ven <arjan@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>,
luto@amacapital.net, peterz@infradead.org, sds@tycho.nsa.gov,
keescook@chromium.org, torvalds@linux-foundation.org,
efault@gmx.de, linux-kernel@vger.kernel.org, mingo@kernel.org,
hpa@zytor.com, tglx@linutronix.de, brgerst@gmail.com,
dvlasenk@redhat.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] x86/mm: Warn on W^X mappings
Date: Thu, 8 Oct 2015 08:00:24 -0700 [thread overview]
Message-ID: <56168508.7030704@linux.intel.com> (raw)
In-Reply-To: <20151008145707.GA17513@nazgul.tnic>
On 10/8/2015 7:57 AM, Borislav Petkov wrote:
>> + pr_info("x86/mm: Checked W+X mappings: passed, no W+X pages found.\n");
> Do we really want to issue anything here in the success case? IMO, we
> should be quiet if the check passes and only scream when something's
> wrong...
I would like the success message to be there.
From an automated testing perspective (for the distro I work on for example),
"the test runs and it fails",
"the test runs and it passes" and
"the test has not run (because of a bug in the code or config file)"
are different outcomes, where the first and third are test failures,
but without the pr_info at info level, the 2nd and 3rd are indistinguishable.
next prev parent reply other threads:[~2015-10-08 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 16:55 [PATCH v3] x86/mm: warn on W+x mappings Stephen Smalley
2015-10-05 19:36 ` Kees Cook
2015-10-06 9:54 ` [tip:x86/mm] x86/mm: Warn on W^X mappings tip-bot for Stephen Smalley
2015-10-06 14:23 ` Arjan van de Ven
2015-10-06 14:49 ` Ingo Molnar
2015-10-08 14:57 ` Borislav Petkov
2015-10-08 15:00 ` Arjan van de Ven [this message]
2015-10-08 15:33 ` Borislav Petkov
2015-10-08 18:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56168508.7030704@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sds@tycho.nsa.gov \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.