* re: net: Microchip encx24j600 driver
@ 2015-10-06 19:00 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-10-06 19:00 UTC (permalink / raw)
To: kernel-janitors
Hello Jon Ringle,
This is a semi-automatic email about new static checker warnings.
The patch 04fbfce7a222: "net: Microchip encx24j600 driver" from Oct
1, 2015, leads to the following Smatch complaint:
drivers/net/ethernet/microchip/encx24j600.c:313 encx24j600_tx_complete()
warn: variable dereferenced before check 'priv->tx_skb' (see line 307)
drivers/net/ethernet/microchip/encx24j600.c
306
307 dev->stats.tx_bytes += priv->tx_skb->len;
^^^^^^^^^^^^
Unchecked dereference.
308
309 encx24j600_clr_bits(priv, EIR, TXIF | TXABTIF);
310
311 netif_dbg(priv, tx_done, dev, "TX Done%s\n", err ? ": Err" : "");
312
313 if (priv->tx_skb) {
^^^^^^^^^^^^
Too late.
314 dev_kfree_skb(priv->tx_skb);
315 priv->tx_skb = NULL;
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-06 19:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-06 19:00 net: Microchip encx24j600 driver Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.