All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 09/10] staging: iio: adc: use BIT macro
Date: Wed, 7 Oct 2015 10:47:36 +0530	[thread overview]
Message-ID: <20151007051736.GD4070@sudip-pc> (raw)
In-Reply-To: <c8e2d47eeef0c65ce13a9b2a8159a92a04686e72.1444172066.git.ciorneiioana@gmail.com>

On Wed, Oct 07, 2015 at 01:57:09AM +0300, Ioana Ciornei wrote:
> Use BIT macro instead of shifting operator in order to improve
> readability
> 
> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
> ---

This is introducing build warnings:

drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_complete_touch_event’:
drivers/staging/iio/adc/mxs-lradc.c:728:6: warning: large integer implicitly truncated to unsigned type [-Woverflow]
      LRADC_DELAY(2));
      ^
drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_buffer_preenable’:
drivers/staging/iio/adc/mxs-lradc.c:1292:8: warning: large integer implicitly truncated to unsigned type [-Woverflow]
        LRADC_DELAY_KICK, LRADC_DELAY(0));
        ^
drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_buffer_postdisable’:
drivers/staging/iio/adc/mxs-lradc.c:1311:8: warning: large integer implicitly truncated to unsigned type [-Woverflow]
        LRADC_DELAY_KICK, LRADC_DELAY(0));
        ^

regards
sudip


  reply	other threads:[~2015-10-07  5:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 22:57 [PATCH 00/10] staging: iio: adc: fix multiple checkpatch issues Ioana Ciornei
2015-10-06 22:57 ` [PATCH 01/10] staging: iio: adc: use kernel types u32 and u64 Ioana Ciornei
2015-10-06 22:57 ` [PATCH 02/10] staging: iio: adc: properly indent to match open paranthesis Ioana Ciornei
2015-10-06 22:57 ` [PATCH 03/10] staging: iio: adc: remove explicit comparison to NULL Ioana Ciornei
2015-10-06 22:57 ` [PATCH 04/10] staging: iio: adc: remove space after cast Ioana Ciornei
2015-10-06 22:57 ` [PATCH 05/10] staging: iio: adc: add spaces around binary operators Ioana Ciornei
2015-10-06 22:57 ` [PATCH 06/10] staging: iio: adc: add blank line after declarations Ioana Ciornei
2015-10-06 22:57 ` [PATCH 07/10] staging: iio: adc: remove multiple blank lines Ioana Ciornei
2015-10-06 22:57 ` [PATCH 08/10] staging: iio: adc: remove the use of CamelCase Ioana Ciornei
2015-10-07  5:14   ` [Outreachy kernel] " Sudip Mukherjee
2015-10-07  6:42     ` Ioana Ciornei
2015-10-07  6:57       ` Sudip Mukherjee
2015-10-07  7:58         ` Ioana Ciornei
2015-10-06 22:57 ` [PATCH 09/10] staging: iio: adc: use BIT macro Ioana Ciornei
2015-10-07  5:17   ` Sudip Mukherjee [this message]
2015-10-07 10:48     ` [Outreachy kernel] " Ioana Ciornei
2015-10-07 11:52       ` Sudip Mukherjee
2015-10-07 11:55         ` Ioana Ciornei
2015-10-06 22:57 ` [PATCH 10/10] staging: iio: adc: properly indent block comments Ioana Ciornei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151007051736.GD4070@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=ciorneiioana@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.