From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH 08/10] staging: iio: adc: remove the use of CamelCase
Date: Wed, 7 Oct 2015 12:27:22 +0530 [thread overview]
Message-ID: <20151007065552.GA20931@sudip-pc> (raw)
In-Reply-To: <CAHWJYFk34=Od-DR26wUiW72YLE6EyP8uJ+oT3p-m2cikUhPGKw@mail.gmail.com>
On Wed, Oct 07, 2015 at 09:42:36AM +0300, Ioana Ciornei wrote:
> On Oct 7, 2015 8:15 AM, "Sudip Mukherjee" <sudipm.mukherjee@gmail.com>
> wrote:
> >
> > On Wed, Oct 07, 2015 at 01:57:08AM +0300, Ioana Ciornei wrote:
> > > Remove the use of CamelCase to follow the kernel naming conventions
<snip>
> > Why did you change AD7192_GPOCON_GP10EN to AD7193_GPOCON_GP10EN?
> >
> > And I donot see any camelcase here, not even in the next few
> > conversions.
> >
>
> Sorry for that change from 92 to 93. My mistake. I will send a v2.
> Regarding the other changes, should I just revert them? Do you consider
> there is no point in converting them?
Had a closer look. Only this AD7192_GPOCON_GP10EN to
AD7193_GPOCON_GP10EN is not camelcase conversion. Remaining all are.
Just leave this one out.
And in a later patch you can even remove this
#define AD7192_GPOCON_GP10EN BIT(4) /* Digital Output P1 and P0 enable */
This one is not used any where and that is the reason you did not see a
build failure with this patch.
regards
sudip
next prev parent reply other threads:[~2015-10-07 6:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 22:57 [PATCH 00/10] staging: iio: adc: fix multiple checkpatch issues Ioana Ciornei
2015-10-06 22:57 ` [PATCH 01/10] staging: iio: adc: use kernel types u32 and u64 Ioana Ciornei
2015-10-06 22:57 ` [PATCH 02/10] staging: iio: adc: properly indent to match open paranthesis Ioana Ciornei
2015-10-06 22:57 ` [PATCH 03/10] staging: iio: adc: remove explicit comparison to NULL Ioana Ciornei
2015-10-06 22:57 ` [PATCH 04/10] staging: iio: adc: remove space after cast Ioana Ciornei
2015-10-06 22:57 ` [PATCH 05/10] staging: iio: adc: add spaces around binary operators Ioana Ciornei
2015-10-06 22:57 ` [PATCH 06/10] staging: iio: adc: add blank line after declarations Ioana Ciornei
2015-10-06 22:57 ` [PATCH 07/10] staging: iio: adc: remove multiple blank lines Ioana Ciornei
2015-10-06 22:57 ` [PATCH 08/10] staging: iio: adc: remove the use of CamelCase Ioana Ciornei
2015-10-07 5:14 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-07 6:42 ` Ioana Ciornei
2015-10-07 6:57 ` Sudip Mukherjee [this message]
2015-10-07 7:58 ` Ioana Ciornei
2015-10-06 22:57 ` [PATCH 09/10] staging: iio: adc: use BIT macro Ioana Ciornei
2015-10-07 5:17 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-07 10:48 ` Ioana Ciornei
2015-10-07 11:52 ` Sudip Mukherjee
2015-10-07 11:55 ` Ioana Ciornei
2015-10-06 22:57 ` [PATCH 10/10] staging: iio: adc: properly indent block comments Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007065552.GA20931@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=ciorneiioana@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.