All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
Date: Wed, 7 Oct 2015 13:01:12 +0200	[thread overview]
Message-ID: <20151007110112.GD3485@piout.net> (raw)
In-Reply-To: <1444163325-3041-1-git-send-email-sylvain.rochet@finsecur.com>

Hi Sylvain,

On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
> Since turning on idle-halt in commit 5161b31dc39a (watchdog:
> at91sam9_wdt: better watchdog support"), SoCs compatible with
> at91sam9260-wdt not using a device tree no longer reboot if the watchdog
> times out while the CPU is in idle state. Removing the
> AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
> 
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
> Cc: <stable@vger.kernel.org> # 3.14+

Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

However, we don't really care about that for kernels after 3.18 as no
users are using pdata anymore.
I think you could send a follow-up patch removing pdata support
completely.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Sylvain Rochet <sylvain.rochet@finsecur.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Ludovic Desroches <ludovic.desroches@atmel.com>,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
Date: Wed, 7 Oct 2015 13:01:12 +0200	[thread overview]
Message-ID: <20151007110112.GD3485@piout.net> (raw)
In-Reply-To: <1444163325-3041-1-git-send-email-sylvain.rochet@finsecur.com>

Hi Sylvain,

On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
> Since turning on idle-halt in commit 5161b31dc39a (watchdog:
> at91sam9_wdt: better watchdog support"), SoCs compatible with
> at91sam9260-wdt not using a device tree no longer reboot if the watchdog
> times out while the CPU is in idle state. Removing the
> AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
> 
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
> Cc: <stable@vger.kernel.org> # 3.14+

Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

However, we don't really care about that for kernels after 3.18 as no
users are using pdata anymore.
I think you could send a follow-up patch removing pdata support
completely.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-10-07 11:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 20:28 [PATCH] watchdog: at91sam9: keep watchdog running in idle mode Sylvain Rochet
2015-10-06 20:28 ` Sylvain Rochet
2015-10-07 11:01 ` Alexandre Belloni [this message]
2015-10-07 11:01   ` Alexandre Belloni
2016-10-16 15:33   ` Sylvain Rochet
2016-10-16 15:33     ` Sylvain Rochet
2016-10-16 15:50     ` Guenter Roeck
2016-10-16 15:50       ` Guenter Roeck
2016-10-16 15:55       ` Guenter Roeck
2016-10-16 15:55         ` Guenter Roeck
2016-10-16 20:39         ` Sylvain Rochet
2016-10-16 20:39           ` Sylvain Rochet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151007110112.GD3485@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.