All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Nishanth Menon <nm@ti.com>, Dmitry Torokhov <dtor@chromium.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PM / OPP: fix debugfs files for 64-bit
Date: Wed, 7 Oct 2015 12:07:55 +0100	[thread overview]
Message-ID: <20151007110755.GA6601@kroah.com> (raw)
In-Reply-To: <20151007110302.GD9892@linux>

On Wed, Oct 07, 2015 at 04:33:02PM +0530, Viresh Kumar wrote:
> On 07-10-15, 16:29, Viresh Kumar wrote:
> > What about adding something like debugfs_create_unsigned_long() for
> > such cases?
> 
> And that can be as simple (or ugly, not sure if its buggy) as:
> 
> debugfs_create_unsigned_long()
> {
>         if (sizeof(unsigned long) == sizeof(u32))
>                 return debugfs_create_u32();
>         if (sizeof(unsigned long) == sizeof(u64))
>                 return debugfs_create_u64();
> 
>         return -EINVAL;
> }

Why would you be wanting to create a "unsigned long" as an api anyway?
Just force it to be u64 all the time, can't you do that?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / OPP: fix debugfs files for 64-bit
Date: Wed, 7 Oct 2015 12:07:55 +0100	[thread overview]
Message-ID: <20151007110755.GA6601@kroah.com> (raw)
In-Reply-To: <20151007110302.GD9892@linux>

On Wed, Oct 07, 2015 at 04:33:02PM +0530, Viresh Kumar wrote:
> On 07-10-15, 16:29, Viresh Kumar wrote:
> > What about adding something like debugfs_create_unsigned_long() for
> > such cases?
> 
> And that can be as simple (or ugly, not sure if its buggy) as:
> 
> debugfs_create_unsigned_long()
> {
>         if (sizeof(unsigned long) == sizeof(u32))
>                 return debugfs_create_u32();
>         if (sizeof(unsigned long) == sizeof(u64))
>                 return debugfs_create_u64();
> 
>         return -EINVAL;
> }

Why would you be wanting to create a "unsigned long" as an api anyway?
Just force it to be u64 all the time, can't you do that?

thanks,

greg k-h

  reply	other threads:[~2015-10-07 11:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07  7:35 [PATCH] PM / OPP: fix debugfs files for 64-bit Arnd Bergmann
2015-10-07  7:35 ` Arnd Bergmann
2015-10-07 10:59 ` Viresh Kumar
2015-10-07 10:59   ` Viresh Kumar
2015-10-07 11:03   ` Viresh Kumar
2015-10-07 11:03     ` Viresh Kumar
2015-10-07 11:07     ` Greg Kroah-Hartman [this message]
2015-10-07 11:07       ` Greg Kroah-Hartman
2015-10-07 11:21       ` Viresh Kumar
2015-10-07 11:21         ` Viresh Kumar
2015-10-07 12:57         ` Greg Kroah-Hartman
2015-10-07 12:57           ` Greg Kroah-Hartman
2015-10-07 13:03           ` Viresh Kumar
2015-10-07 13:03             ` Viresh Kumar
2015-10-07 13:03             ` Viresh Kumar
2015-10-07 17:19             ` Greg Kroah-Hartman
2015-10-07 17:19               ` Greg Kroah-Hartman
2015-10-07 17:27               ` Viresh Kumar
2015-10-07 17:27                 ` Viresh Kumar
2015-10-07 17:39                 ` Greg Kroah-Hartman
2015-10-07 17:39                   ` Greg Kroah-Hartman
2015-10-07 18:00                   ` Viresh Kumar
2015-10-07 18:00                     ` Viresh Kumar
2015-10-07 19:12             ` Arnd Bergmann
2015-10-07 19:12               ` Arnd Bergmann
2015-10-08  7:48               ` Viresh Kumar
2015-10-08  7:48                 ` Viresh Kumar
2015-10-08 14:25                 ` Alan Stern
2015-10-08 14:25                   ` Alan Stern
2015-10-08 14:25                   ` Alan Stern
2015-10-19 15:40                 ` Michael Turquette
2015-10-19 15:40                   ` Michael Turquette
2015-10-19 15:53                   ` Russell King - ARM Linux
2015-10-19 15:53                     ` Russell King - ARM Linux
2015-10-20 10:22                     ` Michael Turquette
2015-10-20 10:22                       ` Michael Turquette
2015-10-07 16:33         ` Russell King - ARM Linux
2015-10-07 16:33           ` Russell King - ARM Linux
2015-10-07 16:36           ` Viresh Kumar
2015-10-07 16:36             ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151007110755.GA6601@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=dtor@chromium.org \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@codeaurora.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.