All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 2/9] staging: iio: adc: properly indent to match open paranthesis
Date: Thu, 8 Oct 2015 10:25:56 +0530	[thread overview]
Message-ID: <20151008045556.GA3294@sudip-pc> (raw)
In-Reply-To: <5db27019c28d1f4d1313654d81e6dc21d562284b.1444241200.git.ciorneiioana@gmail.com>

On Wed, Oct 07, 2015 at 09:13:40PM +0300, Ioana Ciornei wrote:
> Indent parameters ansd arguments passed to function calls to match
> open paranthesis
> 
> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
> ---
This patch will introduce new warning of "line over 80 characters" while
fixing the warning about "Alignment should match open parenthesis".
I am not sure if it is ok to introduce new warnings to fix some other
warnings.

In one of your change in this patch you can do something like:

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index fe56fb6..c30e1b3 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -359,8 +359,9 @@ static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
 		ad7192_read_frequency,
 		ad7192_write_frequency);
 
-static ssize_t ad7192_show_scale_available(struct device *dev,
-			struct device_attribute *attr, char *buf)
+static ssize_t
+ad7192_show_scale_available(struct device *dev,
+			    struct device_attribute *attr, char *buf)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ad7192_state *st = iio_priv(indio_dev);


---
regards
sudip	


  reply	other threads:[~2015-10-08  4:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 18:13 [PATCH v2 0/9] staging: iio: adc: fix multiple checkpatch issues Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 1/9] staging: iio: adc: use kernel types u32 and u64 Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 2/9] staging: iio: adc: properly indent to match open paranthesis Ioana Ciornei
2015-10-08  4:55   ` Sudip Mukherjee [this message]
2015-10-08  5:40     ` [Outreachy kernel] " Julia Lawall
2015-10-08  5:57       ` Ioana Ciornei
2015-10-08  6:49         ` Julia Lawall
2015-10-08  6:52           ` Ioana Ciornei
2015-10-08 18:15             ` Ioana Ciornei
2015-10-09  5:40               ` Sudip Mukherjee
2015-10-07 18:13 ` [PATCH v2 3/9] staging: iio: adc: remove explicit comparison to NULL Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 4/9] staging: iio: adc: remove space after cast Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 5/9] staging: iio: adc: add spaces around binary operators Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 6/9] staging: iio: adc: add blank line after declarations Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 7/9] staging: iio: adc: remove multiple blank lines Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 8/9] staging: iio: adc: remove the use of CamelCase Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 9/9] staging: iio: adc: properly indent block comments Ioana Ciornei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008045556.GA3294@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=ciorneiioana@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.