From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH v2 2/9] staging: iio: adc: properly indent to match open paranthesis
Date: Fri, 9 Oct 2015 11:10:44 +0530 [thread overview]
Message-ID: <20151009054044.GA6059@sudip-pc> (raw)
In-Reply-To: <CAHWJYF=pbh6txTBpJdiPJiQuUmnykfG4ECR0FMw7NXpgZ5VHuA@mail.gmail.com>
On Thu, Oct 08, 2015 at 09:15:04PM +0300, Ioana Ciornei wrote:
> On Thu, Oct 8, 2015 at 9:52 AM, Ioana Ciornei <ciorneiioana@gmail.com> wrote:
> > On Thu, Oct 8, 2015 at 9:49 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >>
> >>
> >> On Thu, 8 Oct 2015, Ioana Ciornei wrote:
> >>
> >>> On Thu, Oct 8, 2015 at 8:40 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >>> >
> >>> >
> >>> > On Thu, 8 Oct 2015, Sudip Mukherjee wrote:
> >>> >
> >>> >> On Wed, Oct 07, 2015 at 09:13:40PM +0300, Ioana Ciornei wrote:
<snip>
> >>
>
> I had a better look at this particular patch and I am still in doubt
> about this one.
> If a indent to match the open brackets I do not see a possible way to
> not cross the 80 characters limit.
>
> I had a try with Sudip's sugestion to put the return type of a
> function on a separate line but that does not apply to all cases.
> What should I do in this situation? It is better to just leave the
> changes that do not introduce warnings or just drop the patch?
I just did one as an example to show you one more way of keeping the
lines in limit. But for other cases where there is no way then you can
either rename the variables (if variable names are long) or you can
refactor the code so that indention is fixed along with that line length
is also fixed and lastly if there is no possible way then I guess we
should chose the one which improves readability.
regards
sudip
next prev parent reply other threads:[~2015-10-09 5:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 18:13 [PATCH v2 0/9] staging: iio: adc: fix multiple checkpatch issues Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 1/9] staging: iio: adc: use kernel types u32 and u64 Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 2/9] staging: iio: adc: properly indent to match open paranthesis Ioana Ciornei
2015-10-08 4:55 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-08 5:40 ` Julia Lawall
2015-10-08 5:57 ` Ioana Ciornei
2015-10-08 6:49 ` Julia Lawall
2015-10-08 6:52 ` Ioana Ciornei
2015-10-08 18:15 ` Ioana Ciornei
2015-10-09 5:40 ` Sudip Mukherjee [this message]
2015-10-07 18:13 ` [PATCH v2 3/9] staging: iio: adc: remove explicit comparison to NULL Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 4/9] staging: iio: adc: remove space after cast Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 5/9] staging: iio: adc: add spaces around binary operators Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 6/9] staging: iio: adc: add blank line after declarations Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 7/9] staging: iio: adc: remove multiple blank lines Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 8/9] staging: iio: adc: remove the use of CamelCase Ioana Ciornei
2015-10-07 18:13 ` [PATCH v2 9/9] staging: iio: adc: properly indent block comments Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009054044.GA6059@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=ciorneiioana@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.