All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: "Nicolas Ferre" <nicolas.ferre@atmel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	"Jiri Slaby" <jslaby@suse.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: atmel: fix compiler warning on address cast
Date: Thu, 8 Oct 2015 11:01:48 +0200	[thread overview]
Message-ID: <20151008090148.GE3485@piout.net> (raw)
In-Reply-To: <1444064452-12285-1-git-send-email-andre.przywara@arm.com>

On 05/10/2015 at 18:00:52 +0100, Andre Przywara wrote :
> Turning on KVM and LPAE support on top of a multi_v7_defconfig will
> produce a compiler warning in the Atmel serial driver:
> drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
> drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   if ((void *)port->mapbase != ser->iomem_base)
>       ^
> 
> Fix that by using the cast on the right hand side instead, as similar
> code already does in other drivers.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

> ---
>  drivers/tty/serial/atmel_serial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index cd30a45..28039ce 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2296,7 +2296,7 @@ static int atmel_verify_port(struct uart_port *port, struct serial_struct *ser)
>  		ret = -EINVAL;
>  	if (port->uartclk / 16 != ser->baud_base)
>  		ret = -EINVAL;
> -	if ((void *)port->mapbase != ser->iomem_base)
> +	if (port->mapbase != (unsigned long)ser->iomem_base)
>  		ret = -EINVAL;
>  	if (port->iobase != ser->port)
>  		ret = -EINVAL;
> -- 
> 2.5.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: atmel: fix compiler warning on address cast
Date: Thu, 8 Oct 2015 11:01:48 +0200	[thread overview]
Message-ID: <20151008090148.GE3485@piout.net> (raw)
In-Reply-To: <1444064452-12285-1-git-send-email-andre.przywara@arm.com>

On 05/10/2015 at 18:00:52 +0100, Andre Przywara wrote :
> Turning on KVM and LPAE support on top of a multi_v7_defconfig will
> produce a compiler warning in the Atmel serial driver:
> drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
> drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   if ((void *)port->mapbase != ser->iomem_base)
>       ^
> 
> Fix that by using the cast on the right hand side instead, as similar
> code already does in other drivers.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

> ---
>  drivers/tty/serial/atmel_serial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index cd30a45..28039ce 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2296,7 +2296,7 @@ static int atmel_verify_port(struct uart_port *port, struct serial_struct *ser)
>  		ret = -EINVAL;
>  	if (port->uartclk / 16 != ser->baud_base)
>  		ret = -EINVAL;
> -	if ((void *)port->mapbase != ser->iomem_base)
> +	if (port->mapbase != (unsigned long)ser->iomem_base)
>  		ret = -EINVAL;
>  	if (port->iobase != ser->port)
>  		ret = -EINVAL;
> -- 
> 2.5.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-10-08  9:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 17:00 [PATCH] serial: atmel: fix compiler warning on address cast Andre Przywara
2015-10-05 17:00 ` Andre Przywara
2015-10-08  9:01 ` Alexandre Belloni [this message]
2015-10-08  9:01   ` Alexandre Belloni
2015-10-08  9:37   ` Russell King - ARM Linux
2015-10-08  9:37     ` Russell King - ARM Linux
2015-10-08 10:38     ` Alexandre Belloni
2015-10-08 10:38       ` Alexandre Belloni
2015-10-08 14:49       ` Andre Przywara
2015-10-08 14:49         ` Andre Przywara
2015-10-08 15:01         ` Russell King - ARM Linux
2015-10-08 15:01           ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008090148.GE3485@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=andre.przywara@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.