From: Willy Tarreau <w@1wt.eu>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Guenter Roeck <linux@roeck-us.net>,
stable <stable@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dingtianhong <dingtianhong@huawei.com>
Subject: Re: Build errors in v3.10-stable-queue
Date: Thu, 8 Oct 2015 15:00:43 +0200 [thread overview]
Message-ID: <20151008130043.GA4522@1wt.eu> (raw)
In-Reply-To: <1444308572.2956.254.camel@decadent.org.uk>
On Thu, Oct 08, 2015 at 01:49:32PM +0100, Ben Hutchings wrote:
> On Sat, 2015-09-26 at 15:20 -0700, Guenter Roeck wrote:
> > drivers/net/bonding/bond_main.c: In function ???bond_get_old_active???:
> > drivers/net/bonding/bond_main.c:884:33: error: macro "bond_for_each_slave" requires 3 arguments, but only 2 given
> > drivers/net/bonding/bond_main.c:884:2: error: ???bond_for_each_slave??? undeclared (first use in this function)
> > drivers/net/bonding/bond_main.c:884:2: note: each undeclared identifier is reported only once for each function it appears in
> > drivers/net/bonding/bond_main.c:884:35: error: expected ???;??? before ???{??? token
> >
> > This affects a large number of builds.
> >
> > Culprit is 'bonding: correct the MAC address for "follow"
> > fail_over_mac policy', which may need a backport.
>
> bond_for_each_slave() needs an int parameter for a counter.
>
> Untested backport attached, based on what I did for 3.2.
I agree with the fix, it's similar to what I proposed (except that
you actually did the patch of course).
Willy
next prev parent reply other threads:[~2015-10-08 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 22:20 Build errors in v3.10-stable-queue Guenter Roeck
2015-10-08 12:49 ` Ben Hutchings
2015-10-08 13:00 ` Willy Tarreau [this message]
2015-10-18 0:10 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008130043.GA4522@1wt.eu \
--to=w@1wt.eu \
--cc=ben@decadent.org.uk \
--cc=dingtianhong@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.