All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <amsfield22@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: checkpatch err - questioning adding parens
Date: Thu, 8 Oct 2015 10:00:13 -0700	[thread overview]
Message-ID: <20151008170011.GA2603@Ubuntu-D830> (raw)

Looking at this checkpatch ERROR and hesitating to change because it
looks worse to my eyes.

ERROR: Macros with complex values should be enclosed in parentheses
FILE: sm750_cursor.c:40:

Here's a short snippet (defines actually go on ~25 lines)

This...
	#define HWC_ADDRESS                         0x0
	#define HWC_ADDRESS_ENABLE                  31:31
	#define HWC_ADDRESS_ENABLE_DISABLE          0
	#define HWC_ADDRESS_ENABLE_ENABLE           1

would become this..
	#define HWC_ADDRESS                         (0x0)
	#define HWC_ADDRESS_ENABLE                  (31:31)
	#define HWC_ADDRESS_ENABLE_DISABLE          (0)
	#define HWC_ADDRESS_ENABLE_ENABLE           (1)

It is an ERROR... so what's my direction?

Thanks,
alisons




             reply	other threads:[~2015-10-08 17:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08 17:00 Alison Schofield [this message]
2015-10-08 17:22 ` [Outreachy kernel] checkpatch err - questioning adding parens Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008170011.GA2603@Ubuntu-D830 \
    --to=amsfield22@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.