checkpatch err - questioning adding parens

checkpatch err - questioning adding parens

[Alison Schofield]

Looking at this checkpatch ERROR and hesitating to change because it
looks worse to my eyes.

ERROR: Macros with complex values should be enclosed in parentheses
FILE: sm750_cursor.c:40:

Here's a short snippet (defines actually go on ~25 lines)

This...
	#define HWC_ADDRESS                         0x0
	#define HWC_ADDRESS_ENABLE                  31:31
	#define HWC_ADDRESS_ENABLE_DISABLE          0
	#define HWC_ADDRESS_ENABLE_ENABLE           1

would become this..
	#define HWC_ADDRESS                         (0x0)
	#define HWC_ADDRESS_ENABLE                  (31:31)
	#define HWC_ADDRESS_ENABLE_DISABLE          (0)
	#define HWC_ADDRESS_ENABLE_ENABLE           (1)

It is an ERROR... so what's my direction?

Thanks,
alisons

Re: [Outreachy kernel] checkpatch err - questioning adding parens

[Greg KH]

On Thu, Oct 08, 2015 at 10:00:13AM -0700, Alison Schofield wrote:
> Looking at this checkpatch ERROR and hesitating to change because it
> looks worse to my eyes.
> 
> ERROR: Macros with complex values should be enclosed in parentheses
> FILE: sm750_cursor.c:40:
> 
> Here's a short snippet (defines actually go on ~25 lines)
> 
> This...
> 	#define HWC_ADDRESS                         0x0
> 	#define HWC_ADDRESS_ENABLE                  31:31
> 	#define HWC_ADDRESS_ENABLE_DISABLE          0
> 	#define HWC_ADDRESS_ENABLE_ENABLE           1
> 
> would become this..
> 	#define HWC_ADDRESS                         (0x0)
> 	#define HWC_ADDRESS_ENABLE                  (31:31)
> 	#define HWC_ADDRESS_ENABLE_DISABLE          (0)
> 	#define HWC_ADDRESS_ENABLE_ENABLE           (1)
> 
> It is an ERROR... so what's my direction?

Just ignore it, it's a "false positive" in checkpatch, sorry about that.

thanks,

greg k-h