All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	sjoerd.simons@collabora.co.uk
Subject: Re: [PATCH 1/3] clk: add flag for clocks that need to be enabled on rate changes
Date: Thu, 8 Oct 2015 14:58:40 -0700	[thread overview]
Message-ID: <20151008215840.GJ26883@codeaurora.org> (raw)
In-Reply-To: <3137165.kmu68gRS44@diego>

On 10/02, Heiko Stübner wrote:
> Hi,
> 
> any comment on these 3 patches?
> 

Dong has a similar problem, but those patches conflate this with
enabling parent clocks during clk_disable_unused() which makes no
sense to me. So I'm ok with the requirement that we turn clocks
on to change rates, but I wonder if in this case we need to turn
on the clock that's changing rates itself, or if we just need to
turn on the parent and/or future parent of the clock during the
rate switch. Care to elaborate on that?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: add flag for clocks that need to be enabled on rate changes
Date: Thu, 8 Oct 2015 14:58:40 -0700	[thread overview]
Message-ID: <20151008215840.GJ26883@codeaurora.org> (raw)
In-Reply-To: <3137165.kmu68gRS44@diego>

On 10/02, Heiko St?bner wrote:
> Hi,
> 
> any comment on these 3 patches?
> 

Dong has a similar problem, but those patches conflate this with
enabling parent clocks during clk_disable_unused() which makes no
sense to me. So I'm ok with the requirement that we turn clocks
on to change rates, but I wonder if in this case we need to turn
on the clock that's changing rates itself, or if we just need to
turn on the parent and/or future parent of the clock during the
rate switch. Care to elaborate on that?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-10-08 21:58 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 17:46 [PATCH 1/3] clk: add flag for clocks that need to be enabled on rate changes Heiko Stuebner
2015-08-21 17:46 ` Heiko Stuebner
2015-08-21 17:46 ` Heiko Stuebner
2015-08-21 17:47 ` [PATCH 2/3] clk: rockchip: handle mux dependency of fractional dividers Heiko Stuebner
2015-08-21 17:47   ` Heiko Stuebner
2015-08-21 17:47   ` Heiko Stuebner
2015-10-05 19:09   ` Sjoerd Simons
2015-10-05 19:09     ` Sjoerd Simons
2015-10-05 19:09     ` Sjoerd Simons
2015-08-21 17:48 ` [PATCH 3/3] clk: rockchip: include downstream muxes into " Heiko Stuebner
2015-08-21 17:48   ` Heiko Stuebner
2015-08-21 17:48   ` Heiko Stuebner
2015-10-05 19:09   ` Sjoerd Simons
2015-10-05 19:09     ` Sjoerd Simons
2015-10-05 19:09     ` Sjoerd Simons
2015-12-12  3:35   ` Caesar Wang
2015-12-12  3:35     ` Caesar Wang
2015-12-12  3:35     ` Caesar Wang
2015-10-02 14:12 ` [PATCH 1/3] clk: add flag for clocks that need to be enabled on rate changes Heiko Stübner
2015-10-02 14:12   ` Heiko Stübner
2015-10-08 21:58   ` Stephen Boyd [this message]
2015-10-08 21:58     ` Stephen Boyd
2015-10-11 10:41     ` Heiko Stübner
2015-10-11 10:41       ` Heiko Stübner
2015-10-11 10:41       ` Heiko Stübner
2015-10-12 16:03       ` Heiko Stübner
2015-10-12 16:03         ` Heiko Stübner
2015-10-12 16:03         ` Heiko Stübner
2015-10-13  3:34         ` Xing Zheng
2015-10-13  3:34           ` Xing Zheng
2015-10-05 19:09 ` Sjoerd Simons
2015-10-05 19:09   ` Sjoerd Simons
2015-10-05 19:09   ` Sjoerd Simons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008215840.GJ26883@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sjoerd.simons@collabora.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.