From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info
Date: Fri, 9 Oct 2015 13:14:30 +0530 [thread overview]
Message-ID: <20151009074430.GA15721@sudip-pc> (raw)
In-Reply-To: <20151009073010.GA40264@ubuntu>
On Fri, Oct 09, 2015 at 01:00:10PM +0530, Shivani Bhardwaj wrote:
> Replaced the function printk() with dev_info() to fix the warning
> generated by checkpatch : printk() should include KERN_ facility level.
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> Changes in v2:
> - Replaced the function pr_info() with dev_info()
>
> drivers/staging/sm750fb/ddk750_help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> index 9637dd3..d20cd92 100644
> --- a/drivers/staging/sm750fb/ddk750_help.c
> +++ b/drivers/staging/sm750fb/ddk750_help.c
> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> devId750 = devId;
> revId750 = revId;
> if (revId == 0xfe)
> - printk("found sm750le\n");
> + dev_info("found sm750le\n");
Did you try to compile it?
regards
sudip
next prev parent reply other threads:[~2015-10-09 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 7:30 [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info Shivani Bhardwaj
2015-10-09 7:44 ` Sudip Mukherjee [this message]
2015-10-09 13:59 ` [Outreachy kernel] " Shivani Bhardwaj
-- strict thread matches above, loose matches on Subject: below --
2015-10-09 14:21 Shivani Bhardwaj
2015-10-10 7:14 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-10 7:24 ` Julia Lawall
2015-10-10 7:38 ` Sudip Mukherjee
2015-10-10 7:40 ` Julia Lawall
2015-10-10 8:07 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009074430.GA15721@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.