All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code
Date: Fri, 9 Oct 2015 16:34:50 +0300	[thread overview]
Message-ID: <20151009133450.GA8597@node> (raw)
In-Reply-To: <5617BB4A.4040704@synopsys.com>

On Fri, Oct 09, 2015 at 06:34:10PM +0530, Vineet Gupta wrote:
> On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote:
> > - pgtable-generic.c: Fold individual #ifdef for each helper into a top
> >   level #ifdef. Makes code more readable
> > 
> > - Converted the stub helpers for !THP to BUILD_BUG() vs. runtime BUG()
> > 
> > Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> 
> Sorry for sounding pushy - an Ack here will unblock me from dumping boat load of
> patches into linux-next via my tree !

I hope you've tested it with different .configs...

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code
Date: Fri, 9 Oct 2015 16:34:50 +0300	[thread overview]
Message-ID: <20151009133450.GA8597@node> (raw)
In-Reply-To: <5617BB4A.4040704@synopsys.com>

On Fri, Oct 09, 2015 at 06:34:10PM +0530, Vineet Gupta wrote:
> On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote:
> > - pgtable-generic.c: Fold individual #ifdef for each helper into a top
> >   level #ifdef. Makes code more readable
> > 
> > - Converted the stub helpers for !THP to BUILD_BUG() vs. runtime BUG()
> > 
> > Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> 
> Sorry for sounding pushy - an Ack here will unblock me from dumping boat load of
> patches into linux-next via my tree !

I hope you've tested it with different .configs...

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

  reply	other threads:[~2015-10-09 13:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 11:43 [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code Vineet Gupta
2015-10-09 11:43 ` Vineet Gupta
2015-10-09 13:04 ` Vineet Gupta
2015-10-09 13:04   ` Vineet Gupta
2015-10-09 13:34   ` Kirill A. Shutemov [this message]
2015-10-09 13:34     ` Kirill A. Shutemov
2015-10-09 13:39     ` Vineet Gupta
2015-10-09 13:39       ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151009133450.GA8597@node \
    --to=kirill@shutemov.name \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.