From: Michael Welling <mwelling-EkmVulN54Sk@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Neil Armstrong
<narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Fionn Cleary <clearyf-/Zw1syy4LHg@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Jarkko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message
Date: Fri, 9 Oct 2015 09:24:51 -0500 [thread overview]
Message-ID: <20151009142451.GA25376@deathstar> (raw)
In-Reply-To: <20151009113810.GD1542-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote:
> On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:
>
> > What is the point of doing this void cast below?
> > Avoiding compiler warning perhaps?
> > Perhaps you can __maybe_unused for the variable instead?
>
> > > + /* Ignore message */
> > > + (void)msg;
>
> You shouldn't need it at all, but yes if there is a good reason to mark
> something as unused the above annotation is better.
Which one?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Michael Welling <mwelling@ieee.org>
To: Mark Brown <broonie@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Fionn Cleary <clearyf@tcd.ie>, Wolfram Sang <wsa@the-dreams.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message
Date: Fri, 9 Oct 2015 09:24:51 -0500 [thread overview]
Message-ID: <20151009142451.GA25376@deathstar> (raw)
In-Reply-To: <20151009113810.GD1542@sirena.org.uk>
On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote:
> On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:
>
> > What is the point of doing this void cast below?
> > Avoiding compiler warning perhaps?
> > Perhaps you can __maybe_unused for the variable instead?
>
> > > + /* Ignore message */
> > > + (void)msg;
>
> You shouldn't need it at all, but yes if there is a good reason to mark
> something as unused the above annotation is better.
Which one?
next prev parent reply other threads:[~2015-10-09 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 14:45 [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message Neil Armstrong
2015-10-08 15:21 ` Michael Welling
2015-10-09 11:38 ` Mark Brown
[not found] ` <20151009113810.GD1542-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-09 14:24 ` Michael Welling [this message]
2015-10-09 14:24 ` Michael Welling
2015-10-14 10:56 ` Mark Brown
2015-10-14 10:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009142451.GA25376@deathstar \
--to=mwelling-ekmvuln54sk@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=clearyf-/Zw1syy4LHg@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.