From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000
Date: Fri, 9 Oct 2015 11:16:13 -0700 [thread overview]
Message-ID: <20151009181613.GA12738@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1510091903240.2257@atull-730U3E-740U3E>
On Fri, Oct 09, 2015 at 07:09:15PM +0100, atull wrote:
> On Thu, 8 Oct 2015, Moritz Fischer wrote:
>
> > --- /dev/null
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -0,0 +1,478 @@
> > +/*
> > + * Copyright (c) 2011-2015 Xilinx Inc.
> > + * Copyright (c) 2015, National Instruments Corp.
> > + *
> > + * FPGA Manager Driver for Xilinx Zynq, heavily based on xdevcfg driver
> > + * in their vendor tree.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; version 2 of the License.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <linux/clk.h>
> > +#include <linux/completion.h>
> > +#include <linux/delay.h>
> > +#include <linux/dma-mapping.h>
> > +#include <linux/fpga/fpga-mgr.h>
> > +#include <linux/io.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/module.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/pm.h>
> > +#include <linux/regmap.h>
> > +#include <linux/string.h>
>
> Hi Moritz,
>
> That was fast! I just have a couple of very minor comments...
>
> Please alphabetize the #includes.
Bah, who cares about that, it's not a requirement at all.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: atull <atull@opensource.altera.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, dinguyen@opensource.altera.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000
Date: Fri, 9 Oct 2015 11:16:13 -0700 [thread overview]
Message-ID: <20151009181613.GA12738@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1510091903240.2257@atull-730U3E-740U3E>
On Fri, Oct 09, 2015 at 07:09:15PM +0100, atull wrote:
> On Thu, 8 Oct 2015, Moritz Fischer wrote:
>
> > --- /dev/null
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -0,0 +1,478 @@
> > +/*
> > + * Copyright (c) 2011-2015 Xilinx Inc.
> > + * Copyright (c) 2015, National Instruments Corp.
> > + *
> > + * FPGA Manager Driver for Xilinx Zynq, heavily based on xdevcfg driver
> > + * in their vendor tree.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; version 2 of the License.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <linux/clk.h>
> > +#include <linux/completion.h>
> > +#include <linux/delay.h>
> > +#include <linux/dma-mapping.h>
> > +#include <linux/fpga/fpga-mgr.h>
> > +#include <linux/io.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/module.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/pm.h>
> > +#include <linux/regmap.h>
> > +#include <linux/string.h>
>
> Hi Moritz,
>
> That was fast! I just have a couple of very minor comments...
>
> Please alphabetize the #includes.
Bah, who cares about that, it's not a requirement at all.
greg k-h
next prev parent reply other threads:[~2015-10-09 18:16 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 22:45 [PATCH 0/3] Adding Xilinx Zynq 7000 FPGA Manager driver Moritz Fischer
2015-10-08 22:45 ` Moritz Fischer
2015-10-08 22:45 ` [PATCH 1/3] doc: dt: fpga: Added Documentation for Xilinx Zynq FPGA manager Moritz Fischer
2015-10-08 22:45 ` Moritz Fischer
2015-10-09 16:04 ` Josh Cartwright
2015-10-09 16:04 ` Josh Cartwright
2015-10-12 9:31 ` Michal Simek
2015-10-12 9:31 ` Michal Simek
2015-10-12 9:31 ` Michal Simek
2015-10-12 20:41 ` Moritz Fischer
2015-10-12 20:41 ` Moritz Fischer
2015-10-12 16:33 ` Sören Brinkmann
2015-10-12 16:33 ` Sören Brinkmann
2015-10-12 16:33 ` Sören Brinkmann
2015-10-12 21:24 ` Moritz Fischer
2015-10-12 21:24 ` Moritz Fischer
2015-10-08 22:45 ` [PATCH 2/3] dts: Updated devicetree bindings for Zynq 7000 platform Moritz Fischer
2015-10-08 22:45 ` Moritz Fischer
2015-10-12 9:32 ` Michal Simek
2015-10-12 9:32 ` Michal Simek
2015-10-12 9:32 ` Michal Simek
2015-10-14 2:50 ` Moritz Fischer
2015-10-14 2:50 ` Moritz Fischer
2015-10-14 7:03 ` Michal Simek
2015-10-14 7:03 ` Michal Simek
2015-10-14 7:03 ` Michal Simek
2015-10-12 16:19 ` Sören Brinkmann
2015-10-12 16:19 ` Sören Brinkmann
2015-10-12 16:19 ` Sören Brinkmann
2015-10-08 22:45 ` [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000 Moritz Fischer
2015-10-08 22:45 ` Moritz Fischer
2015-10-09 16:33 ` Josh Cartwright
2015-10-09 16:33 ` Josh Cartwright
2015-10-09 16:33 ` Josh Cartwright
2015-10-09 17:17 ` Moritz Fischer
2015-10-09 17:17 ` Moritz Fischer
2015-10-12 11:16 ` Michal Simek
2015-10-12 11:16 ` Michal Simek
2015-10-12 11:16 ` Michal Simek
2015-10-12 12:22 ` Mike Looijmans
2015-10-12 12:22 ` Mike Looijmans
2015-10-12 12:22 ` Mike Looijmans
2015-10-12 12:38 ` Michal Simek
2015-10-12 12:38 ` Michal Simek
2015-10-12 12:38 ` Michal Simek
2015-10-13 5:33 ` Mike Looijmans
2015-10-13 5:33 ` Mike Looijmans
2015-10-13 5:33 ` Mike Looijmans
2015-10-13 12:52 ` Michal Simek
2015-10-13 12:52 ` Michal Simek
2015-10-13 12:52 ` Michal Simek
2015-10-09 18:09 ` atull
2015-10-09 18:09 ` atull
2015-10-09 18:09 ` atull
2015-10-09 18:16 ` Greg KH [this message]
2015-10-09 18:16 ` Greg KH
2015-10-09 18:23 ` atull
2015-10-09 18:23 ` atull
2015-10-09 18:23 ` atull
2015-10-12 2:22 ` Moritz Fischer
2015-10-12 2:22 ` Moritz Fischer
2015-10-12 2:22 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009181613.GA12738@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.