From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mans Rullgard <mans@mansr.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-cris-kernel@axis.com, linux-mips@linux-mips.org,
linux-xtensa@linux-xtensa.org, kernel@stlinux.com,
linux-rpi-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] sched_clock: add data pointer argument to read callback
Date: Sat, 10 Oct 2015 00:20:15 +0100 [thread overview]
Message-ID: <20151009232015.GC32536@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1444427858-576-1-git-send-email-mans@mansr.com>
On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote:
> This passes a data pointer specified in the sched_clock_register()
> call to the read callback allowing simpler implementations thereof.
>
> In this patch, existing uses of this interface are simply updated
> with a null pointer.
This is a bad description. It tells us what the patch is doing,
(which we can see by reading the patch) but not _why_. Please include
information on why the change is necessary - describe what you are
trying to achieve.
I generally don't accept patches what add new stuff to the kernel with
no users of that new stuff - that's called experience, experience of
people who submit stuff like that, and then vanish leaving their junk
in the kernel without any users. Please ensure that this gets a user
very quickly, or better still, submit this patch as part of a series
which makes use of it.
Also, copying soo many people is guaranteed to be silently dropped by
mailing lists.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sched_clock: add data pointer argument to read callback
Date: Sat, 10 Oct 2015 00:20:15 +0100 [thread overview]
Message-ID: <20151009232015.GC32536@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1444427858-576-1-git-send-email-mans@mansr.com>
On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote:
> This passes a data pointer specified in the sched_clock_register()
> call to the read callback allowing simpler implementations thereof.
>
> In this patch, existing uses of this interface are simply updated
> with a null pointer.
This is a bad description. It tells us what the patch is doing,
(which we can see by reading the patch) but not _why_. Please include
information on why the change is necessary - describe what you are
trying to achieve.
I generally don't accept patches what add new stuff to the kernel with
no users of that new stuff - that's called experience, experience of
people who submit stuff like that, and then vanish leaving their junk
in the kernel without any users. Please ensure that this gets a user
very quickly, or better still, submit this patch as part of a series
which makes use of it.
Also, copying soo many people is guaranteed to be silently dropped by
mailing lists.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-09 23:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 21:57 [PATCH] sched_clock: add data pointer argument to read callback Mans Rullgard
2015-10-09 23:20 ` Russell King - ARM Linux [this message]
2015-10-09 23:20 ` Russell King - ARM Linux
2015-10-09 23:48 ` Måns Rullgård
2015-10-09 23:48 ` Måns Rullgård
2015-10-09 23:48 ` Måns Rullgård
2015-10-09 23:54 ` Russell King - ARM Linux
2015-10-09 23:54 ` Russell King - ARM Linux
2015-10-10 0:42 ` Måns Rullgård
2015-10-10 0:42 ` Måns Rullgård
2015-10-10 15:33 ` Russell King - ARM Linux
2015-10-10 15:33 ` Russell King - ARM Linux
2015-10-11 20:40 ` Thomas Gleixner
2015-10-11 20:40 ` Thomas Gleixner
2015-10-12 13:02 ` Gregory CLEMENT
2015-10-12 13:02 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009232015.GC32536@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mans@mansr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.