All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Michael Chan <mchan@broadcom.com>
Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH] bnxt_en: fix returnvar.cocci warnings
Date: Sat, 10 Oct 2015 20:24:22 +0800	[thread overview]
Message-ID: <20151010122422.GA58392@ivytown2> (raw)
In-Reply-To: <1444477151-2225-1-git-send-email-mchan@broadcom.com>

drivers/net/ethernet/broadcom/bnxt/bnxt.c:1290:5-7: Unneeded variable: "rc". Return "0" on line 1304


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Michael Chan <mchan@broadcom.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 bnxt.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -1287,7 +1287,6 @@ next_rx_no_prod:
 static int bnxt_async_event_process(struct bnxt *bp,
 				    struct hwrm_async_event_cmpl *cmpl)
 {
-	int rc = 0;
 	u16 event_id = le16_to_cpu(cmpl->event_id);
 
 	/* TODO CHIMP_FW: Define event id's for link change, error etc */
@@ -1301,7 +1300,7 @@ static int bnxt_async_event_process(stru
 			   event_id);
 		break;
 	}
-	return rc;
+	return 0;
 }
 
 static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)

  parent reply	other threads:[~2015-10-10 12:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10 11:39 [PATCH net-next] bnxt_en: New Broadcom ethernet driver Michael Chan
2015-10-10 12:23 ` kbuild test robot
2015-10-10 12:24 ` kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix semicolon.cocci warnings kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix array_size.cocci warnings kbuild test robot
2015-10-10 12:24 ` kbuild test robot [this message]
2015-10-10 12:24 ` [PATCH] bnxt_en: fix simple_return.cocci warnings kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix returnvar.cocci warnings kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix simple_return.cocci warnings kbuild test robot
2015-10-10 15:51 ` [PATCH net-next] bnxt_en: New Broadcom ethernet driver Joe Perches
2015-10-10 17:00 ` kbuild test robot
2015-10-10 19:17 ` kbuild test robot
2015-10-11  6:54 ` Dmitry Kravkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151010122422.GA58392@ivytown2 \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@01.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.